Seems like there's a simple solution, let's not use 'mvn:' as the prefix if we 
aren't using the Maven coordinate system.

Any ideas on a better prefix?  'karaf:' or 'aether:'

As well, do you have any reference to Aether that shows this alternate 
coordinates?


-David

On May 9, 2013, at 12:38 AM, Romain Manni-Bucau <[email protected]> wrote:

> Hi
> 
> That's normal:
> - matches better default case
> - consistent with karaf/aether
> ---------- Message transféré ----------
> De : <[email protected]>
> Date : 9 mai 2013 08:30
> Objet : svn commit: r1480535 -
> /tomee/tomee/trunk/utils/openejb-provisionning/src/main/java/org/apache/openejb/resolver/maven/Parser.java
> À : <[email protected]>
> 
> Author: dblevins
> Date: Thu May  9 06:30:22 2013
> New Revision: 1480535
> 
> URL: http://svn.apache.org/r1480535
> Log:
> Doesn't seem like the coordinates used in this chunk of code match the
> maven coordinate system.
> 
> Modified:
> 
> tomee/tomee/trunk/utils/openejb-provisionning/src/main/java/org/apache/openejb/resolver/maven/Parser.java
> 
> Modified:
> tomee/tomee/trunk/utils/openejb-provisionning/src/main/java/org/apache/openejb/resolver/maven/Parser.java
> URL:
> http://svn.apache.org/viewvc/tomee/tomee/trunk/utils/openejb-provisionning/src/main/java/org/apache/openejb/resolver/maven/Parser.java?rev=1480535&r1=1480534&r2=1480535&view=diff
> ==============================================================================
> ---
> tomee/tomee/trunk/utils/openejb-provisionning/src/main/java/org/apache/openejb/resolver/maven/Parser.java
> (original)
> +++
> tomee/tomee/trunk/utils/openejb-provisionning/src/main/java/org/apache/openejb/resolver/maven/Parser.java
> Thu May  9 06:30:22 2013
> @@ -19,6 +19,22 @@ package org.apache.openejb.resolver.mave
> import java.net.MalformedURLException;
> import org.ops4j.pax.url.maven.commons.MavenRepositoryURL;
> 
> +/**
> + * This class doesn't seem compliant with the documented Maven Coordinates
> of
> + *
> + *  - groupId:artifactId:packaging:classifier:version
> + *
> + * http://maven.apache.org/pom.html#Maven_Coordinates
> + *
> + * For example, per the output of `mvn dependency:tree` TomEE is:
> + *
> + *  - org.apache.openejb:apache-tomee:zip:webprofile:1.6.0-SNAPSHOT
> + *
> + * It instead seems to use its own non-maven coordinates of
> + *
> + *  - groupId:artifactId:version:packaging:classifier
> + *
> + */
> public class Parser {
>     public static final String VERSION_LATEST = "LATEST";
>     private static final String SYNTAX =
> "mvn:[repository_url!]groupId/artifactId[/[version]/[type]]";

Reply via email to