Hi Jean-Louis! Thank you for the answer!
My user ID is ivannov :) I tried to create a patch file out of my git commit, but I am afraid it doesn't look as expected. It has too many changes inside. I'm afraid I don't have experience with contributing to SVN based projects. I would appreciate if you tell me how I can create the patch file for you to review. Otherwise, here is my commit in github: https://github.com/ivannov/tomee/commit/f0c0b486a0254b7b01b0bb6b46bb39f87d126efc . Cheers, Ivan On Tue, Jan 7, 2014 at 3:15 PM, Jean-Louis MONTEIRO <[email protected]>wrote: > Hi Ivan, > > Apologize for the late answer. > First of, happy new year. > > - any committers can assign the Jira to you. But I need your Jira ID to > find you and add you as a contributor. > - you can just create a patch file for the changes and attach it to the > Jira. > > Someone can review it and commit it for you > > JLouis > > > > > > > > 2014/1/4 Ivan St. Ivanov <[email protected]> > > > Hey everybody! > > > > I wish you very happy, healthy and successful 2014! > > > > Today I brought my first change to my local Tomee repository on Github. I > > was working on this item: > > https://issues.apache.org/jira/browse/OPENEJB-678. > > > > I have a couple of questions though: > > > > - I can't assign the issue in Apache JIRA to my name. Maybe I have to get > > permissions for that? My user name there is ivannov > > - I rebased my local branch to trunk, then I added my commit and pushed > it > > to github. Then I created a pull request. However github tries wants to > > merge it to apache/tomee-1.5.2, together with 906 other commits. I don't > > know how to make it go to trunk > > > > Cheers, > > Ivan > > > > > > -- > Jean-Louis >
