Hello from Finland, Ivan :) Went ahead and committed the patch as it looked good to me. Thanks for poking on the list -- sometimes necessary -- and congratulations on the first patch!
Go for a second one and I'll make sure it gets in way faster! :) Some Java EE 7 fun is right around the corner -- we can use all the hands we can get. -David On Jan 31, 2014, at 4:24 PM, "Ivan St. Ivanov" <[email protected]> wrote: > Hi folks, > > Did you manage to merge this? Or you still have questions on it? > > Cheers, > Ivan > > > On Thu, Jan 9, 2014 at 5:24 PM, Ivan St. Ivanov > <[email protected]>wrote: > >> Well, I understand it this way: >> >> It is not correct to have parameters in a callback method. So *there is >> already* an error message for that situation: *{0} method signature >> "{1}({2})" in class {3} has invalid arguments. The required method >> signature is "void {1}(4)"*. However, some developers may confuse the >> callback methods and the interceptors. So, to make their life easier, there >> is this feature that whenever we find such a method, we tell them more >> clearly: *Invalid usage of javax.interceptor.InvocationContext as >> parameter type of callback method {1} in bean class {0}. Parameters of type >> InvocationContext are only allowed for interceptors.* >> >> >> On Thu, Jan 9, 2014 at 3:57 PM, Romain Manni-Bucau >> <[email protected]>wrote: >> >>> then no sure I get the issue, "you can't use parameters with this kind >>> of method" sounds quite explicit to me, no? >>> Romain Manni-Bucau >>> Twitter: @rmannibucau >>> Blog: http://rmannibucau.wordpress.com/ >>> LinkedIn: http://fr.linkedin.com/in/rmannibucau >>> Github: https://github.com/rmannibucau >>> >>> >>> >>> 2014/1/9 Ivan St. Ivanov <[email protected]>: >>>> Hi Romain, >>>> >>>> I understood it that it is a check that would produce a meaningful >>> message >>>> when someone writes a callback method with the idea in mind that they >>> write >>>> an interceptor method. >>>> >>>> There is already a more general check (the one that you ask for) that >>> would >>>> prevent someone having parameters in the callback methods. However, this >>>> produces a generic message. >>>> >>>> Cheers, >>>> Ivan >>>> >>>> >>>> >>>> >>>> On Thu, Jan 9, 2014 at 3:21 PM, Romain Manni-Bucau < >>> [email protected]>wrote: >>>> >>>>> reformatted it (i can't apply it now), it should work >>>>> >>>>> btw shouldn't the check be more strict and check more than only >>>>> InvocationContext? seems like a particular case we can make generic >>>>> without hurting >>>>> Romain Manni-Bucau >>>>> Twitter: @rmannibucau >>>>> Blog: http://rmannibucau.wordpress.com/ >>>>> LinkedIn: http://fr.linkedin.com/in/rmannibucau >>>>> Github: https://github.com/rmannibucau >>>>> >>>>> >>>>> >>>>> 2014/1/9 Ivan St. Ivanov <[email protected]>: >>>>>> Hi Romain, Jean-Louis! >>>>>> >>>>>> With the help of a colleague of mine, I generated a diff from git. I >>> have >>>>>> attached it to the issue < >>>>> https://issues.apache.org/jira/browse/OPENEJB-678>. >>>>>> Would you please tell me whether it works? >>>>>> >>>>>> Cheers, >>>>>> Ivan >>>>>> >>>>>> P.S. I promise to start using SVN from now on ;) >>>>>> >>>>>> >>>>>> On Wed, Jan 8, 2014 at 11:26 AM, Romain Manni-Bucau >>>>>> <[email protected]>wrote: >>>>>> >>>>>>> well, not sure how we can merge pull request btw (I know maven does >>> it >>>>>>> but they have some infra, not sure we have ATM), the easier is to >>> send >>>>>>> us (attaching it to jira) a patch we can apply from the tomee trunk >>>>>>> (patch -p0 < yourpatch.patch). >>>>>>> Romain Manni-Bucau >>>>>>> Twitter: @rmannibucau >>>>>>> Blog: http://rmannibucau.wordpress.com/ >>>>>>> LinkedIn: http://fr.linkedin.com/in/rmannibucau >>>>>>> Github: https://github.com/rmannibucau >>>>>>> >>>>>>> >>>>>>> >>>>>>> 2014/1/8 Ivan St. Ivanov <[email protected]>: >>>>>>>> Hi folks, >>>>>>>> >>>>>>>> That is what I tried to ask in the first message in this thread: >>>>>>>> >>>>>>>> - I rebased my local branch to trunk, then I added my commit and >>>>> pushed >>>>>>> it >>>>>>>> to github. Then I created a pull request. However github wants to >>>>> merge >>>>>>> it >>>>>>>> to apache/tomee-1.5.2, together with 906 other commits. I don't >>> know >>>>> how >>>>>>> to >>>>>>>> make it go to trunk >>>>>>>> >>>>>>>> Cheers, >>>>>>>> Ivan >>>>>>>> >>>>>>>> >>>>>>>> On Wed, Jan 8, 2014 at 11:17 AM, Romain Manni-Bucau >>>>>>>> <[email protected]>wrote: >>>>>>>> >>>>>>>>> Hi >>>>>>>>> >>>>>>>>> https://github.com/apache/tomee/pull/2/files seems a pretty big >>>>> diff, >>>>>>>>> are you sure you rebased correctly? >>>>>>>>> Romain Manni-Bucau >>>>>>>>> Twitter: @rmannibucau >>>>>>>>> Blog: http://rmannibucau.wordpress.com/ >>>>>>>>> LinkedIn: http://fr.linkedin.com/in/rmannibucau >>>>>>>>> Github: https://github.com/rmannibucau >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> 2014/1/8 Jean-Louis MONTEIRO <[email protected]>: >>>>>>>>>> Ivan, >>>>>>>>>> >>>>>>>>>> Creating a patch file is really trivial. Just add ".patch" at >>> the >>>>> end >>>>>>> of >>>>>>>>>> the URL you gave me. >>>>>>>>>> The main issue there is that your pull request is currently >>> also >>>>>>>>> including >>>>>>>>>> a lot of more changes. >>>>>>>>>> >>>>>>>>>> Jean-Louis >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> 2014/1/8 Ivan St. Ivanov <[email protected]> >>>>>>>>>> >>>>>>>>>>> Hi Jean-Louis! >>>>>>>>>>> >>>>>>>>>>> Here is the pull request: >>> https://github.com/apache/tomee/pull/2 >>>>>>>>>>> >>>>>>>>>>> I would appreciate if you tell me how to create the patch >>> myself >>>>> :) >>>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> Ivan >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On Wed, Jan 8, 2014 at 10:27 AM, Jean-Louis MONTEIRO < >>>>>>>>> [email protected] >>>>>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi Ivan, >>>>>>>>>>>> >>>>>>>>>>>> The JIRA is affected to you now and I added you as a >>>>> contributor. >>>>>>>>>>>> We did not switch yet on git. That's why I asked for a patch >>>>>>> instead >>>>>>>>> of a >>>>>>>>>>>> pull request. >>>>>>>>>>>> >>>>>>>>>>>> Can you give me the link of the pull request? >>>>>>>>>>>> >>>>>>>>>>>> Thanks >>>>>>>>>>>> JLouis >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> 2014/1/7 Ivan St. Ivanov <[email protected]> >>>>>>>>>>>> >>>>>>>>>>>>> Hi Jean-Louis! >>>>>>>>>>>>> >>>>>>>>>>>>> Thank you for the answer! >>>>>>>>>>>>> >>>>>>>>>>>>> My user ID is ivannov :) >>>>>>>>>>>>> >>>>>>>>>>>>> I tried to create a patch file out of my git commit, but >>> I am >>>>>>>>> afraid it >>>>>>>>>>>>> doesn't look as expected. It has too many changes inside. >>>>>>>>>>>>> >>>>>>>>>>>>> I'm afraid I don't have experience with contributing to >>> SVN >>>>> based >>>>>>>>>>>> projects. >>>>>>>>>>>>> I would appreciate if you tell me how I can create the >>> patch >>>>> file >>>>>>>>> for >>>>>>>>>>> you >>>>>>>>>>>>> to review. Otherwise, here is my commit in github: >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>> >>>>>>> >>>>> >>> https://github.com/ivannov/tomee/commit/f0c0b486a0254b7b01b0bb6b46bb39f87d126efc >>>>>>>>>>>>> . >>>>>>>>>>>>> >>>>>>>>>>>>> Cheers, >>>>>>>>>>>>> Ivan >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> On Tue, Jan 7, 2014 at 3:15 PM, Jean-Louis MONTEIRO < >>>>>>>>>>> [email protected] >>>>>>>>>>>>>> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> Hi Ivan, >>>>>>>>>>>>>> >>>>>>>>>>>>>> Apologize for the late answer. >>>>>>>>>>>>>> First of, happy new year. >>>>>>>>>>>>>> >>>>>>>>>>>>>> - any committers can assign the Jira to you. But I need >>> your >>>>>>> Jira >>>>>>>>> ID >>>>>>>>>>> to >>>>>>>>>>>>>> find you and add you as a contributor. >>>>>>>>>>>>>> - you can just create a patch file for the changes and >>>>> attach >>>>>>> it >>>>>>>>> to >>>>>>>>>>> the >>>>>>>>>>>>>> Jira. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Someone can review it and commit it for you >>>>>>>>>>>>>> >>>>>>>>>>>>>> JLouis >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> 2014/1/4 Ivan St. Ivanov <[email protected]> >>>>>>>>>>>>>> >>>>>>>>>>>>>>> Hey everybody! >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> I wish you very happy, healthy and successful 2014! >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Today I brought my first change to my local Tomee >>>>> repository >>>>>>> on >>>>>>>>>>>>> Github. I >>>>>>>>>>>>>>> was working on this item: >>>>>>>>>>>>>>> https://issues.apache.org/jira/browse/OPENEJB-678. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> I have a couple of questions though: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> - I can't assign the issue in Apache JIRA to my name. >>>>> Maybe I >>>>>>>>> have >>>>>>>>>>> to >>>>>>>>>>>>> get >>>>>>>>>>>>>>> permissions for that? My user name there is ivannov >>>>>>>>>>>>>>> - I rebased my local branch to trunk, then I added my >>>>> commit >>>>>>> and >>>>>>>>>>>> pushed >>>>>>>>>>>>>> it >>>>>>>>>>>>>>> to github. Then I created a pull request. However >>> github >>>>>>> tries >>>>>>>>>>> wants >>>>>>>>>>>> to >>>>>>>>>>>>>>> merge it to apache/tomee-1.5.2, together with 906 >>> other >>>>>>>>> commits. I >>>>>>>>>>>>> don't >>>>>>>>>>>>>>> know how to make it go to trunk >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Cheers, >>>>>>>>>>>>>>> Ivan >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> -- >>>>>>>>>>>>>> Jean-Louis >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> Jean-Louis >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Jean-Louis >>>>>>>>> >>>>>>> >>>>> >>> >> >>
