On Feb 13, 2014, at 4:16 AM, Ivan St. Ivanov <[email protected]> wrote:
> I think that there is some work to be done in GitHub. The tomee "central" > repository's main branch seems to be 1.5.3, which is far behind master > (i.e. trunk). Looks like that might have been fixed when Infra hooked up the new features today. I didn't see it before, so take a look at let me know if we need them to tweak it: - https://github.com/apache/tomee > Talking about processes, nearly two weeks ago I attached a patch file in > this JIRA issue: https://issues.apache.org/jira/browse/OPENEJB-679.How can > I make sure that a patch gets reviewed? In GitHub projects it is the pull > request... Thanks for the poke -- it helps and is not viewed as pushy :) I was in Sweden at JFokus when the patch was posted and just got back Monday night. I'll make sure that patch is committed! In situations like that definitely feel encouraged to keep hacking. We'll catch up :) And thank you so much for even wanting to hack, that's really awesome :) -David > > Cheers, > Ivan > > > On Thu, Feb 13, 2014 at 12:24 PM, helio frota <[email protected]> wrote: > >> Cool, >> >> But for instance, using the philosophy of "start small" the process can be >> changed doing a PR from github to be analised from you guys right ? >> >> http://tomee.apache.org/dev/contribution-tips.html >> >> ( feedback ) the example 'simple-stateful' >> >> public class CounterTest { >> >> //START SNIPPET: local >> @Test >> public void test() throws Exception { >> >> final Context context = >> EJBContainer.createEJBContainer().getContext(); >> >> Counter counterA = (Counter) >> context.lookup("java:global/simple-stateful/Counter"); >> >> Assert.assertEquals(0, counterA.count()); >> Assert.assertEquals(0, counterA.reset()); >> Assert.assertEquals(1, counterA.increment()); >> Assert.assertEquals(2, counterA.increment()); >> Assert.assertEquals(0, counterA.reset()); >> >> counterA.increment(); >> counterA.increment(); >> counterA.increment(); >> counterA.increment(); >> >> Assert.assertEquals(4, counterA.count()); >> >> // Get a new counter >> Counter counterB = (Counter) >> context.lookup("java:global/simple-stateful/Counter"); >> >> // The new bean instance starts out at 0 >> Assert.assertEquals(0, counterB.count()); >> } >> //END SNIPPET: local >> >> } >> >> Thanks >> >> >> >> On Thu, Feb 13, 2014 at 4:14 AM, Romain Manni-Bucau >> <[email protected]>wrote: >> >>> sadly we can't merge PR from github but already a huge advancement! >>> Romain Manni-Bucau >>> Twitter: @rmannibucau >>> Blog: http://rmannibucau.wordpress.com/ >>> LinkedIn: http://fr.linkedin.com/in/rmannibucau >>> Github: https://github.com/rmannibucau >>> >>> >>> >>> 2014-02-13 3:48 GMT+01:00 David Blevins <[email protected]>: >>>> Wow. Absolutely, that looks like some *really* great advancements. >>>> >>>> Looks like we'll have to buy the Infra guys/gals a round of beer at >>> ApacheCon this April. So fantastic. >>>> >>>> Filed a JIRA to get us hooked up: >>>> >>>> - https://issues.apache.org/jira/browse/INFRA-7315 >>>> >>>> Really great. >>>> >>>> >>>> -David >>>> >>>> On Feb 12, 2014, at 4:31 PM, helio frota <[email protected]> wrote: >>>> >>>>> Hi ! >>>>> >>>>> This is valid to tomEE right ? >>>>> >>>>> >>> >> https://blogs.apache.org/infra/entry/improved_integration_between_apache_and >>>>> >>>>> Thanks ! >>>>> >>>>> >>>>> >>>>> -- >>>>> * cejug committer - hurraa >>>>> * cejug committer - footprint >>>> >>> >> >> >> >> -- >> * cejug committer - hurraa >> * cejug committer - footprint >>
