Got it. I've fixed that and pushed to the GitHub PR. I also created a patch file containing the same contents and attached it to the corresponding JIRA: https://issues.apache.org/jira/browse/OPENEJB-2071
Tommy On Wed, Feb 26, 2014 at 1:51 PM, Romain Manni-Bucau <[email protected]>wrote: > reset? you use system and not systemInstance to do it so it is not > enough. Some tests are not well written (and examples too) but not a > reason to do the same ;). I'll try to apply your patch (if you can > attach one to a jira) tomorrow if nobody did it before. > Romain Manni-Bucau > Twitter: @rmannibucau > Blog: http://rmannibucau.wordpress.com/ > LinkedIn: http://fr.linkedin.com/in/rmannibucau > Github: https://github.com/rmannibucau > > > > 2014-02-26 12:57 GMT+01:00 Tommy Tynjä <[email protected]>: > > Is reset not sufficent as in > > > https://github.com/tommysdk/tomee/commit/a089d90abab4dd0382467963e4a284e87be6a237 > ? > > Should probably be implemented in other test cases as well which are > > setting the property but not resetting it. > > > > I'll leave the PR at GitHub then since it is considered an option. > Thought > > I would have gotten some feedback on it by now though. > > > > Tommy > > > > > > On Wed, Feb 26, 2014 at 10:20 AM, Romain Manni-Bucau > > <[email protected]>wrote: > > > >> Hello > >> > >> you forgot to clear the property in cleanupTestCase is not existing > >> otherwise looks good. > >> > >> Side note: standard way is to open a jira and attach a patch (we aply > >> it with patch -p0 < ...) but we try to use github too but that's still > >> new. > >> Romain Manni-Bucau > >> Twitter: @rmannibucau > >> Blog: http://rmannibucau.wordpress.com/ > >> LinkedIn: http://fr.linkedin.com/in/rmannibucau > >> Github: https://github.com/rmannibucau > >> > >> > >> > >> 2014-02-26 9:58 GMT+01:00 Tommy Tynjä <[email protected]>: > >> > Hi. > >> > > >> > What is the preferred way to submit code to TomEE? I opened a GitHub > pull > >> > request for OPENEJB-2071 over two weeks ago after having it reviewed > on > >> the > >> > dev list but it has still not been merged or even commented on. I > noticed > >> > there are other pull requests hanging around on GitHub as well. Is > GitHub > >> > supposed to be used for such contributions? > >> > > >> > Best regards, > >> > Tommy Tynjä > >> >
