actually both are prod ready and since we have 2 ds we can use both ;). We can also do two tests for sure but the test setup should be as simple as possible, copying deps is already a bit too much and makes test understanding a bit longer (at least for me ;))
Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-04-17 10:44 GMT+02:00 Andy Gumbrecht <[email protected]>: > I think examples should lean towards production scenarios first, then magic > after. > > The user will see how the test references the two physically separate files > and make sense of it. > > The mvn reference should be a new test class to demonstrate that the magic > exists. > > I will work on the readme today and include the description. > > Andy. > > > On 17/04/2014 10:33, Romain Manni-Bucau wrote: >> >> right, the point was about configuration if it was a bit unclear, not >> the choice ;) >> >> >> Romain Manni-Bucau >> Twitter: @rmannibucau >> Blog: http://rmannibucau.wordpress.com/ >> LinkedIn: http://fr.linkedin.com/in/rmannibucau >> Github: https://github.com/rmannibucau >> >> >> 2014-04-17 10:26 GMT+02:00 Andy Gumbrecht <[email protected]>: >>> >>> I just took two versions of the driver, the very latest and the very >>> earliest. >>> >>> >>> On 17/04/2014 09:21, Romain Manni-Bucau wrote: >>>> >>>> yep, that's what I thought >>>> >>>> >>>> Romain Manni-Bucau >>>> Twitter: @rmannibucau >>>> Blog: http://rmannibucau.wordpress.com/ >>>> LinkedIn: http://fr.linkedin.com/in/rmannibucau >>>> Github: https://github.com/rmannibucau >>>> >>>> >>>> 2014-04-17 9:19 GMT+02:00 Jean-Louis Monteiro >>>> <[email protected]>: >>>>> >>>>> both :) >>>>> Creating 2 datasources using one driver version from maven and another >>>>> from >>>>> a copy dep? >>>>> >>>>> -- >>>>> Jean-Louis Monteiro >>>>> http://twitter.com/jlouismonteiro >>>>> http://www.tomitribe.com >>>>> >>>>> >>>>> On Thu, Apr 17, 2014 at 9:11 AM, Romain Manni-Bucau >>>>> <[email protected]>wrote: >>>>> >>>>>> it should be supported already but the question is what do we put in >>>>>> sample? >>>>>> >>>>>> >>>>>> Romain Manni-Bucau >>>>>> Twitter: @rmannibucau >>>>>> Blog: http://rmannibucau.wordpress.com/ >>>>>> LinkedIn: http://fr.linkedin.com/in/rmannibucau >>>>>> Github: https://github.com/rmannibucau >>>>>> >>>>>> >>>>>> 2014-04-17 9:09 GMT+02:00 Jean-Louis Monteiro >>>>>> <[email protected]>: >>>>>>> >>>>>>> +1, supporting both is fine >>>>>>> >>>>>>> -- >>>>>>> Jean-Louis Monteiro >>>>>>> http://twitter.com/jlouismonteiro >>>>>>> http://www.tomitribe.com >>>>>>> >>>>>>> >>>>>>> On Thu, Apr 17, 2014 at 8:53 AM, Romain Manni-Bucau >>>>>>> <[email protected]>wrote: >>>>>>> >>>>>>>> Hi >>>>>>>> >>>>>>>> Andy added a sample for datasource versioning sample. I helped a bit >>>>>>>> to make it green and we used classpath="path". I wonder if instead >>>>>>>> of >>>>>>>> using maven to copy in drivers/ the drivers to use we shouldn't use >>>>>>>> mvn path in classpath: <Resource ... >>>>>>>> classpath="mvn:org.apache.derby:derby-...:10.10..."> >>>>>>>> >>>>>>>> >>>>>>>> throughts? >>>>>>>> >>>>>>>> >>>>>>>> Romain Manni-Bucau >>>>>>>> Twitter: @rmannibucau >>>>>>>> Blog: http://rmannibucau.wordpress.com/ >>>>>>>> LinkedIn: http://fr.linkedin.com/in/rmannibucau >>>>>>>> Github: https://github.com/rmannibucau >>>>>>>> >>> -- >>> Andy Gumbrecht >>> >>> http://www.tomitribe.com >>> [email protected] >>> https://twitter.com/AndyGeeDe >>> >>> TomEE treibt Tomitribe! | http://tomee.apache.org >>> >> > > -- > Andy Gumbrecht > > http://www.tomitribe.com > [email protected] > https://twitter.com/AndyGeeDe > > TomEE treibt Tomitribe! | http://tomee.apache.org >
