Maybe someone can update this document. "Include the JIRA number and title (if there is a jira). I try never to say "Fixed FOO-2543" all by itself." - http://tomee.apache.org/dev/tips-and-suggestions.html
This was already the proposed and agreed commit message format from some years ago, but these things have a way of getting lost every few years as committers come and go. There's a handful of other guidelines on that page such as don't reformat code and make logic changes in the same commit, etc. Might be good to clean it up and get everyone to take a fresh look. -David On May 16, 2014, at 10:53 AM, Jean-Louis Monteiro <[email protected]> wrote: > +1 works fine for me. > > JLouis > > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro > http://www.tomitribe.com > > > On Fri, May 16, 2014 at 8:31 AM, Romain Manni-Bucau > <[email protected]>wrote: > >> Hi guys, >> >> a quick message to try to normalize a bit commit messages (I blame >> nobody that's for me too ;) ). >> >> If working against a jira would be great to use (my proposal but can >> be discussed): [JIRA NAME] [short description in english] >> >> For instance: >> >> "TOMEE-8888 change default value foo attribute in tomee.xml" >> >> Main goal is to avoid things like: >> >> "working on TOMEE-4568" or " >> https://issues.apache.org/jira/browse/TOMEE-8756"; >> >> This is hard to re-browse history without textual description >> >> >> Romain Manni-Bucau >> Twitter: @rmannibucau >> Blog: http://rmannibucau.wordpress.com/ >> LinkedIn: http://fr.linkedin.com/in/rmannibucau >> Github: https://github.com/rmannibucau >>
