well, fail = test fails or an exception is logged? IIRC an exception should
be logged (lazy to setup everything) but the connector is setup (that was
the test)



Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau
Github: https://github.com/rmannibucau


2014-07-19 20:45 GMT+02:00 [email protected] <
[email protected]>:

> The issue was that ssl was/is being started for the test, but it is not
> specified? The missing keystore causes the fail.
>
> Sent from my HTC
>
> ----- Reply message -----
> From: "Romain Manni-Bucau" <[email protected]>
> To: "[email protected]" <[email protected]>
> Subject: svn commit: r1611909 -
> /tomee/tomee/branches/tomee-1.7.x/maven/tomee-maven-plugin/src/main/java/org/apache/openejb/maven/plugin/AbstractTomEEMojo.java
> Date: Sat, Jul 19, 2014 19:19
>
> Hmm, not sure
>
> if user wants https and https is commented then uncomment the block
> otherwise use server.xml as it. That's what was here
>
>
> Romain Manni-Bucau
> Twitter: @rmannibucau
> Blog: http://rmannibucau.wordpress.com/
> LinkedIn: http://fr.linkedin.com/in/rmannibucau
> Github: https://github.com/rmannibucau
>
>
> ---------- Forwarded message ----------
> From: <[email protected]>
> Date: 2014-07-19 15:05 GMT+02:00
> Subject: svn commit: r1611909 -
>
> /tomee/tomee/branches/tomee-1.7.x/maven/tomee-maven-plugin/src/main/java/org/apache/openejb/maven/plugin/AbstractTomEEMojo.java
> To: [email protected]
>
>
> Author: andygumbrecht
> Date: Sat Jul 19 13:05:13 2014
> New Revision: 1611909
>
> URL: http://svn.apache.org/r1611909
> Log:
> Don't configure https unless specified - Looks like a typo, but will
> confirm with author.
>
> Modified:
>
>
> tomee/tomee/branches/tomee-1.7.x/maven/tomee-maven-plugin/src/main/java/org/apache/openejb/maven/plugin/AbstractTomEEMojo.java
>
> Modified:
>
> tomee/tomee/branches/tomee-1.7.x/maven/tomee-maven-plugin/src/main/java/org/apache/openejb/maven/plugin/AbstractTomEEMojo.java
> URL:
>
> http://svn.apache.org/viewvc/tomee/tomee/branches/tomee-1.7.x/maven/tomee-maven-plugin/src/main/java/org/apache/openejb/maven/plugin/AbstractTomEEMojo.java?rev=1611909&r1=1611908&r2=1611909&view=diff
>
> ==============================================================================
> ---
>
> tomee/tomee/branches/tomee-1.7.x/maven/tomee-maven-plugin/src/main/java/org/apache/openejb/maven/plugin/AbstractTomEEMojo.java
> (original)
> +++
>
> tomee/tomee/branches/tomee-1.7.x/maven/tomee-maven-plugin/src/main/java/org/apache/openejb/maven/plugin/AbstractTomEEMojo.java
> Sat Jul 19 13:05:13 2014
> @@ -633,7 +633,7 @@ public abstract class AbstractTomEEMojo
>
> String value = read(serverXml);
>
> -        if (tomeeHttpsPort != null && tomeeHttpsPort > 0 &&
> parser.value("HTTPS", null) == null) {
> +        if (tomeeHttpsPort != null && tomeeHttpsPort > 0 &&
> parser.value("HTTPS", null) != null) {
> // ensure connector is not commented
> value = value.replace("<Service name=\"Catalina\">", "<Service
> name=\"Catalina\">\n"
> + "    <Connector port=\"" + tomeeHttpsPort + "\"
> protocol=\"HTTP/1.1\" SSLEnabled=\"true\"\n" +
> @@ -753,9 +753,9 @@ public abstract class AbstractTomEEMojo
>
> server.setPortStartup(tomeeHttpPort);
>
> -            getLog().info("Running '" +
> getClass().getSimpleName().replace("TomEEMojo",
> "").toLowerCase(Locale.ENGLISH)
> +            getLog().info("Running '" +
> getClass().getName().replace("TomEEMojo", "").toLowerCase(Locale.ENGLISH)
> + "'. Configured TomEE in plugin is " + tomeeHost + ":" +
> tomeeHttpPort
> -                + " (plugin shutdown port is " + tomeeShutdownPort + ")");
> +                + " (plugin shutdown port is " + tomeeShutdownPort + ") "
> + tomeeHttpsPort);
> } else {
> getLog().info("Running '" +
> getClass().getSimpleName().replace("TomEEMojo",
> "").toLowerCase(Locale.ENGLISH));
> }
>

Reply via email to