well to be honest it was in xbean 4 upgrade which changed so much things that this was the least issue at the moment and that's why it passed through the release this way.
WHat I'm not sure is we should have a test about it somewhere (when I added ModuleLimitedFinder). But doesn't hurt to add one for tomee embedded (where we miss some tests surely) Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-09-24 10:24 GMT+02:00 Andy Gumbrecht <[email protected]>: > It's a nice feature, but I think ensuring backwards compatibility is > essential to keeping existing users happy - Marius obviously spent a lot of > time tracking this down and the resolution is down to your extreme in depth > knowledge of internals. > > "just add openejb.finder.module-scoped=true" (To > [tomee]/conf/system.properties btw.) is a small statement with a huge > impact. We can't all have you in our back pocket, but great that you are > here on the forum for these things. > > However, things like this must without question be in the release > announcement and not tucked away in notes, especially if the default / > existing functionality has changed. > > It's too late to change now (I will still add it to the page though), but we > all have to be careful not to drive people away with issues like this. I > would rather see the test from Marius in the project to ensure that it is > not repeated. > > Andy. > > > On 24/09/2014 10:03, Romain Manni-Bucau wrote: >> >> 2014-09-24 9:50 GMT+02:00 Andy Gumbrecht <[email protected]>: >>> >>> What does openejb.finder.module-scoped=true do, where is it documented >>> and >>> should it then not be true by default if it breaks previous >>> functionality? >>> >> it ensure we don't scan classes outside current module. >> >> should it be true? yes and no. In 80% of apps it doesn't change >> anything excepted it goes really faster for big apps. >> >> you can set it to true by default if you think that's better but TCKs >> and out tests don't care AFAIK. >> >>> Andy. >>> >>> On 24/09/2014 08:02, Romain Manni-Bucau wrote: >>>> >>>> Hi >>>> >>>> just add openejb.finder.module-scoped=true >>>> >>>> >>>> -- >>>> ✝ Marius >>> >>> >>> >>> -- >>> Andy Gumbrecht >>> https://twitter.com/AndyGeeDe >>> http://www.tomitribe.com >>> >> > > -- > Andy Gumbrecht > https://twitter.com/AndyGeeDe > http://www.tomitribe.com >
