Hi there,

I'm currently trying to get in touch with Tomee/OpenEJB's codebase in
order to gain more insights about it.

My usual procedure is to run a clean build in order to verify that
everything works fine before I make an attempt to provide some patches.

Unfortunately the build is not completely passing through
(http://svn.apache.org/repos/asf/tomee/tomee/trunk@1629078) even
though I disabled the tests. Checked under Windows 7 (my main system)
as well as under Ubuntu Linux.

So basically I have some questions to get the build properly going:

* Is there a Continuous Integration system and if so, where can I find
it ? I failed to locate a link on the tomee site.

* What is the general policy regarding the code quality ? I mean
usually I intend to keep everything going, so if someone breaks a
build he's responsible to solve it.

* The contribution site points out that it's common practice to use
final variables and fields. Can someone elaborate on this ? I see that
a lot but in open source code but I think there's usually no point in
doing that (I can elaborate on that).

* I personally would focus first on refactorings in order to get the
code more readable (I've seen several methods that are too long for
me). One nice tool for this would be lombok
(http://projectlombok.org/). I know that it's supported through
Eclipse/IDEA and Maven. Are there any objections ?


Best regards

Daniel Kasmeroglu



Reply via email to