Le 15 oct. 2014 22:24, "Daniel Kasmeroglu" <[email protected]> a écrit : > > Am 15.10.2014 um 22:10 schrieb Romain Manni-Bucau: > > Hmm > > > > Should be in openejb-loader not core. > > > Right. > > > That said ok if it stays localized where used ie maven resolver other -1. > > > I'm not sure what you're meaning with that. I certainly don't intend to > touch the dependencies for these constants. >
Dont put it in a Constant.java or Maven.java > > About the test we should pass it as system prop in surefire, was it your > > idea? Issue about this test is we dont use maven where the plugin does. It > > was cause maven harness was broken when written but now it is fixed and we > > should be able to use it. > > > For testing purposes I would just pass the property using the maven > commandline as most people probably are using the default location. > > However my question wasn't about the specific property > 'openejb.m2.home'. It was about dealing with properties in OpenEJB/Tomee > in general. > Perso i try to create constants only when reusable. The m2 one for instance is almost internal and not that used at runtime so -+0 to have a constant for it, in particular cause we can desire to switch it later at runtime (one reason why some theorically constants are not static final) This little warning said a big review would be welcomed > > Best regards > > Daniel Kasmeroglu >
