Here is my +1 Looks good to me. The issue is not a blocking issue imho, so we can re-roll later.
-- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Tue, May 12, 2015 at 2:35 PM, Romain Manni-Bucau <[email protected]> wrote: > 2015-05-12 23:31 GMT+02:00 Andy Gumbrecht <[email protected]>: > > > If you want to relocate the entire .m2 then using 'openejb.m2.home' is a > > good option. The custom repo location is defined most commonly by the > > standard .m2 <settings><localRepository> tag. It's more simple and out of > > the box to read that first if it is available than to force the setting > of > > a custom property for every single Arquillian test/project. It is also a > > step better than just expecting a hard coded {user.home}.m2/repository. > The > > issue here is to be able to right click on a test and run it without > > errors, and without having to set any undocumented properties. That would > > also go against several of the guiding principles of Arquillian. > > > > > Just wanted to say it is fine to release without it + it is really trivial > to do the bridge using maven to set the system property on surefire (+ any > good IDE will inherit from the config for free). So the m2 part is clearly > not an issue. Windows one is. > > > > Andy. > > > > On 12/05/2015 22:52, Romain Manni-Bucau wrote: > > > >> Side note: our mvn resolver was never intended to replace maven (for it > >> you > >> have to add provisioning module) and read maven descriptors (in > particular > >> now maven has 5-6 descriptors in homeand at least 3 which can modify the > >> local repo). Custom repo should be handled by setting openejb.m2.home. > If > >> you want it to be global you can set it in ~/.openejb/system.properties. > >> > >> > >> Romain Manni-Bucau > >> @rmannibucau <https://twitter.com/rmannibucau> | Blog > >> <http://rmannibucau.wordpress.com> | Github < > >> https://github.com/rmannibucau> | > >> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber > >> <http://www.tomitribe.com> > >> > >> 2015-05-12 22:15 GMT+02:00 Andy <[email protected]>: > >> > >> -1 > >>> > >>> Build 414 here: http://ci.apache.org/builders/tomee-1.7.x-ubuntu > >>> Revision: ae7f37b7622272f82644c03cc50305b23728763c > >>> > >>> Contains fixes for ProvisioningUtil that ensures alternate > .m2/repository > >>> location is used if found in settings.xml and fixes a path issue on > >>> Windows > >>> platforms (partial revert, my mistake). > >>> > >>> Andy. > >>> > >>> -- > >>> Andy Gumbrecht > >>> https://twitter.com/AndyGeeDe > >>> > >>> > >>> > >> -- > >> Andy Gumbrecht > >> https://twitter.com/AndyGeeDe > >> http://www.tomitribe.com > >> > > >
