please review
https://git1-us-west.apache.org/repos/asf?p=tomee.git;a=commit;h=1f25711f565d6d8c7d0072cc79e60f509d50dce5


Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
<http://www.tomitribe.com>

2015-06-10 9:10 GMT+02:00 Romain Manni-Bucau <[email protected]>:

> Hi Andy,
>
> just saw the ~10 lines of code around
> https://github.com/apache/tomee/blob/master/maven/tomee-maven-plugin/src/main/java/org/apache/openejb/maven/plugin/AbstractTomEEMojo.java#L865
>
> Enhancing keystore support is great!
>
> I wonder if we can make it evolving a bit to not explicitely rely on local
> configuration because build mojo inherit from this config (I guess you use
> it with run?) and then it can create issues if build on a machine having
> such files then deployed on another one missing them.
>
> Can be copying the cert, generating one or anything else.
>
> wdyt? Do you want to hack on it? Happy jump on it once you sent your
> feedbackt if you are busy.
>
> Side note: instead of "project" we can get project.build.directory
> injected.
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <http://rmannibucau.wordpress.com> | Github
> <https://github.com/rmannibucau> | LinkedIn
> <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> <http://www.tomitribe.com>
>

Reply via email to