Hi Jonathan, I will raise an issue, and is happy to send a pull request via GitHub. It's good to see that TomEE accepts pull requests like that.
Thanks, Kasun On Wed, Aug 5, 2015 at 3:45 PM, Jonathan Gallimore <[email protected] > wrote: > Hi there > > Thanks for raising this. Can you create a JIRA for this here: > https://issues.apache.org/jira? If you want to have a go at the fix, just > let us know and submit either a patch attached to the JIRA issue or a pull > request through GitHub. If not, I'll happily pick this up and fix. > > We've had a few fixes on the 1.7.x branch now, so we could look at rolling > a new release pretty soon. > > Regards > > Jon > > On Wed, Aug 5, 2015 at 11:10 AM, Kasun Gajasinghe <[email protected]> > wrote: > > > Hi TomEE devs, > > > > We've been seeing the following exception [2] in an instance where we > have > > extended TomEE 1.7.2. We have debugged the issue, and it seems to have > > occurred since TomEE iterate over the System.getProperties() hashtable > [1]. > > It's possible that other threads might be using the system properties > which > > could lead to ConcurrentModificationException. > > > > Best way fix thing would to create a clone of the system properties, and > > use that clone to iterate. There are issues reported for unsafe iterating > > of system properties in other projects as seen in [3]. > > > > Can we get this fixed in TomEE 1.7.3? What do I need to do to get this > in? > > > > Thanks. > > > > [1] > > > > > https://github.com/apache/tomee/blob/tomee-1.7.x/container/openejb-loader/src/main/java/org/apache/openejb/loader/SystemInstance.java#L71 > > > > [2] > > org.apache.openejb.loader.LoaderRuntimeException: Failed to create > default > > instance of SystemInstance > > at > org.apache.openejb.loader.SystemInstance.reset(SystemInstance.java:280) > > at > > > org.apache.openejb.loader.SystemInstance.<clinit>(SystemInstance.java:265) > > ... 9 more > > Caused by: java.util.ConcurrentModificationException > > at java.util.Hashtable$Enumerator.next(Hashtable.java:1167) > > at > org.apache.openejb.loader.SystemInstance.<init>(SystemInstance.java:71) > > at > org.apache.openejb.loader.SystemInstance.reset(SystemInstance.java:277) > > ... 10 more > > > > [3] > > https://bugs.eclipse.org/bugs/show_bug.cgi?id=469706 > > https://liquibase.jira.com/browse/CORE-2104 > > > > > > -- > Jonathan Gallimore > http://twitter.com/jongallimore > http://www.tomitribe.com > -- ~~~*******'''''''''''''*******~~~ *Kasun Gajasinghe* Software Engineer; WSO2 Inc.; http://wso2.com, *linked-in: *http://lk.linkedin.com/in/gajasinghe *blog: **http://blog.kasunbg.org* <http://blog.kasunbg.org/> *twitter: **http://twitter.com/kasunbg* <http://twitter.com/kasunbg>
