It may not break anything because the fix is handled in exception case and the 
problem is very clear, but I am not sure  :)
Otherwise, as you said we can redirect these scripts to catalina.sh or 
completely remove the scripts.

Best
Gurkan 


     On Sunday, August 30, 2015 5:39 PM, Romain Manni-Bucau 
<[email protected]> wrote:
   

 2015-08-30 16:32 GMT+02:00 Gurkan Erdogdu <[email protected]>:

Hi Romain

tomee.sh is a great because it starts standalone OpenEJB server, not TomEE. 
Therefore, I think that we have to fix the exception problem :)  Otherwise, may 
not put these scripts to bin/ folder. Some customers play with TomEE and when 
gets exception like this, they think that it is not production ready. My patch 
fixes the problem.


Hehe, not sure it fixes it but hides it well ;). My point is in TomEE mode - 
default in tomee distribution - a lot of classloading and services assumptions 
are done. Starting a TomEE as OpenEJB needs a lot of carefulness and more code 
I fear. Typically the stop command will likely not work and if you make it 
working hacking services config you can break your server if you use some 
tomcat listeners.
What would be the issue to redirect these script to catalina.sh? I guess stop 
is 1-1 and start is catalina.sh run. I agree it is then a script fix and not a 
java one but it sounds saner to me. 
Best
Gurkan

     On Sunday, August 30, 2015 5:28 PM, Romain Manni-Bucau 
<[email protected]> wrote:


 Oh I see!

tomee.sh start/stop commands are not intended to be used with tomee ATM,
they are inherited from openejb embedded but dont start/stop tomee like a
tomcat, we should redirect them to catalina.sh I think. This sounds like a
better fix ;).

./catalina.sh run or start shouldnt have any issue.


Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
<http://www.tomitribe.com>

2015-08-30 16:07 GMT+02:00 Gurkan Erdogdu <[email protected]>:

> Hi Romain
> I downloaded the apache-tomee-1.7.2-plus.tar.gz and I run it in Mac OSX
> Yosemite 10.10.4 with JDK 1.7.0_72-b14. There is no custom configuration.
> Reproduce of the issue:
> 1- Download fresh TomEE Plus 1.7.2 from
> http://tomee.apache.org/downloads.html2- Untar it to any folder3- cd bin/
> directory
> 4- ./tomee.sh start
> It throws the exception:
> Aug 30, 2015 5:00:43 PM org.apache.openejb.assembler.classic.Assembler
> deployMBean
> SEVERE: the mbean
> org.apache.openejb.assembler.classic.ReloadableEntityManagerFactory$JMXReloadableEntityManagerFactory
> can't be registered because it can't be instantiated
> java.lang.InstantiationException:
> org.apache.openejb.assembler.classic.ReloadableEntityManagerFactory$JMXReloadableEntityManagerFactory
>    at java.lang.Class.newInstance(Class.java:364)
>    at
> org.apache.openejb.assembler.classic.Assembler.deployMBean(Assembler.java:1421)
>    at
> org.apache.openejb.assembler.classic.Assembler.createApplication(Assembler.java:944)
>    at
> org.apache.openejb.assembler.classic.Assembler.createApplication(Assembler.java:652)
>    at
> org.apache.openejb.assembler.classic.Assembler.buildContainerSystem(Assembler.java:543)
>    at
> org.apache.openejb.assembler.classic.Assembler.build(Assembler.java:439)
>    at org.apache.openejb.OpenEJB$Instance.<init>(OpenEJB.java:150)
>    at org.apache.openejb.OpenEJB.init(OpenEJB.java:298)
>    at org.apache.openejb.server.Server.init(Server.java:65)
>    at org.apache.openejb.server.Main.initServer(Main.java:154)
>    at org.apache.openejb.server.Main.main(Main.java:128)
>    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>    at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>    at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>    at java.lang.reflect.Method.invoke(Method.java:606)
>    at org.apache.openejb.cli.MainImpl.main(MainImpl.java:148)
>    at org.apache.openejb.cli.Bootstrap.main(Bootstrap.java:106)
>
> Aug 30, 2015 5:00:43 PM org.apache.openejb.assembler.classic.Assembler
> deployMBean
> INFO: Deployed
> MBean(openejb.user.mbeans:application=openejb-core-4.7.2,group=org.apache.openejb.assembler.monitoring,name=JMXDeployer)
> Aug 30, 2015 5:00:43 PM org.apache.openejb.assembler.classic.Assembler
> deployMBean
> SEVERE: the mbean
> org.apache.openejb.resource.GeronimoTransactionManagerFactory$TransactionManagerMBean
> can't be registered because it can't be instantiated
> java.lang.InstantiationException:
> org.apache.openejb.resource.GeronimoTransactionManagerFactory$TransactionManagerMBean
>    at java.lang.Class.newInstance(Class.java:364)
>    at
> org.apache.openejb.assembler.classic.Assembler.deployMBean(Assembler.java:1421)
>    at
> org.apache.openejb.assembler.classic.Assembler.createApplication(Assembler.java:944)
>    at
> org.apache.openejb.assembler.classic.Assembler.createApplication(Assembler.java:652)
>    at
> org.apache.openejb.assembler.classic.Assembler.buildContainerSystem(Assembler.java:543)
>    at
> org.apache.openejb.assembler.classic.Assembler.build(Assembler.java:439)
>    at org.apache.openejb.OpenEJB$Instance.<init>(OpenEJB.java:150)
>    at org.apache.openejb.OpenEJB.init(OpenEJB.java:298)
>    at org.apache.openejb.server.Server.init(Server.java:65)
>    at org.apache.openejb.server.Main.initServer(Main.java:154)
>    at org.apache.openejb.server.Main.main(Main.java:128)
>    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>    at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>    at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>    at java.lang.reflect.Method.invoke(Method.java:606)
>    at org.apache.openejb.cli.MainImpl.main(MainImpl.java:148)
>    at org.apache.openejb.cli.Bootstrap.main(Bootstrap.java:106)
> Best
> Gurkan
>
>
>      On Sunday, August 30, 2015 4:52 PM, Romain Manni-Bucau <
> [email protected]> wrote:
>
>
>  Hi Gurkan,
>
> It would probably be better to fix the issue instead of working it around
> in the Assembler. Here few question to try to nail it down:
>
> - we are several to have tested tomee under windows lately and we didnt get
> it so what is different with your setup (home/base? custom classpath?
> specific config?...)
> - the 2 classes you reference are NOT scanned so not instantiated
> automatically - if so your setup has an issue - they are instantiated by
> the container when needed
>
> Can you try to give us more info about your setup before we consider the
> issue as invalid or not reproducible please?
>
>
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> <http://www.tomitribe.com>
>
> 2015-08-29 23:34 GMT+02:00 Gurkan Erdogdu <[email protected]
> >:
>
> > Hello folks,
> > I opened a new issue regarding the subject.
> > https://issues.apache.org/jira/browse/TOMEE-1628
> > Best
> > Gurkan
> >
> >
>
>
>
>


  



  

Reply via email to