sounds good, if it can be done by module - dont know if there is a maven plugin for that - it sounds great.
Romain Manni-Bucau @rmannibucau | Blog | Github | LinkedIn | Tomitriber 2015-11-19 8:47 GMT-08:00 Raquel Pau Fernández <[email protected]>: > Hi, > > The execution time depends on the transformations you want to apply. In the > guava example, walkmod is compiling source code, applying semantic analysis > and removing dead code. If you just want to correct formatting issues, it > will really become faster. > > If you don't want such history, you need to run walkmod locally selecting > the hole project, a module or a set of files (your modified files). > > > > > 2015-11-19 17:37 GMT+01:00 Romain Manni-Bucau <[email protected]>: > >> 2015-11-19 8:23 GMT-08:00 Raquel Pau Fernández <[email protected]>: >> > Test for Tomme: >> > >> > I can do it during the next week an adaptation of the source code to >> > provide an option to force an specific End Line and execute it for the >> > entire project and send a PR. However, Walkmod assumes that at least >> there >> > is one code transformation (not pure formatting). So, if this is the >> > scenario I need to adapt more parts. However, confirm this is what you >> want >> > :) >> > >> > Regarding the execution time: >> > >> > I have run walkmod on guava core, for example: 52 sec for 473 files. >> > However, it does not require to be executed for all the source code, you >> > can select the subset of files you want to process. Moreover, there is a >> > free service online (because it is beta) to process the pushed files and >> > send a PR if it is needed. >> > >> >> for just the .java we have 5327 files so if linear it would make ~10mn >> which is quite a lot for a local run which would be nice to avoid >> formatting commits - I guess it is one of the goals of such a work. >> >> If we split in "modules" the execution, one module we touch a lot has >> 1534 files (openejb-core) so would still add 3mn to the build which is >> probably too much. Any way to make it insanely fast if we select only >> few validations/corrections? >> >> Personally I'd like to be able to integrate the diff before pushing to >> avoid an history like: >> >> [EOL] >> [formatting] >> [adding test] >> [fixing test] >> [formatting] >> [another cool feature] >> [formatting] >> [awesome feature #1] >> >> >> Does walkmod can do it and would it stay free for such a usage? >> >> For EOL I know checkstyle can validate it and ant (antrun plugin?) can >> fix it in place. It just tackles a small part of the formatting but it >> is the one the most intrusive ATM it seems. >> >> >> > Any feedback is appreaciated >> > >> > >> > 2015-11-19 17:12 GMT+01:00 Romain Manni-Bucau <[email protected]>: >> > >> >> Is it hard - in term of time - to get an estimation of the changes it >> >> would imply and get a kind of preview/diff? Anyone able to work on it? >> >> I can help a bit next week if needed. >> >> >> >> Romain Manni-Bucau >> >> @rmannibucau | Blog | Github | LinkedIn | Tomitriber >> >> >> >> >> >> 2015-11-19 8:09 GMT-08:00 Raquel Pau Fernández <[email protected]>: >> >> > Hi, >> >> > >> >> > I am the project lead of Walkmod. I would like to add to Alex comments >> >> that >> >> > another important feature is that it allows just to apply your code >> >> > conventions without rewriting the hole code base according an specific >> >> > formatter. Consequently, its executions do not need to reformat all >> your >> >> > code. It just removes or add those pieces of code in the appropiate >> gap >> >> > without rewriting all your source code. E.g. if you want to ensure >> that >> >> > there is no dead code or apply an specific license. >> >> > >> >> > It also respects the Line End of each source file but, if you want I >> can >> >> > work on adapting it to ensure an specific Line End. >> >> > >> >> > >> >> > 2015-11-19 16:36 GMT+01:00 Alex Soto <[email protected]>: >> >> > >> >> >> The good thing about Walkmod is that you don't relay on IDE >> >> configuration, >> >> >> it is a separated process that can generate a PR with the changes so >> all >> >> >> code is uniform. >> >> >> >> >> >> El dj., 19 nov. 2015 a les 16:35, Andy Gumbrecht (< >> >> >> [email protected]>) >> >> >> va escriure: >> >> >> >> >> >> > +1 on anything that promotes a globally uniform format. >> >> >> > >> >> >> > Still need the IDEA settings import/export to match whatever is >> >> >> configured. >> >> >> > >> >> >> > Someone on unix box will have to ensure everything is LF except >> maybe >> >> >> > *.bat & *.cmd <- Not sure how to handle that, but can be done in >> >> >> > .gitattributes I think? >> >> >> > >> >> >> > -- >> >> >> > Andy Gumbrecht >> >> >> > https://twitter.com/AndyGeeDe >> >> >> > http://www.tomitribe.com >> >> >> > >> >> >> > >> >> >> >> >> > >> >> > >> >> > >> >> > -- >> >> > Raquel Pau >> >> > >> >> > *"Education is the most powerful weapon which you can use to change >> the >> >> > world**"* >> >> > >> >> > Nelson Mandela >> >> > >> >> > personal page: >> >> > http://sites.google.com/site/raquelpau/ >> >> >> > >> > >> > >> > -- >> > Raquel Pau >> > >> > *"Education is the most powerful weapon which you can use to change the >> > world**"* >> > >> > Nelson Mandela >> > >> > personal page: >> > http://sites.google.com/site/raquelpau/ >> > > > > -- > Raquel Pau > > *"Education is the most powerful weapon which you can use to change the > world**"* > > Nelson Mandela > > personal page: > http://sites.google.com/site/raquelpau/
