Then -1 for code "guess" of Idea. A lot of false positives so it pollutes code and when you read it then you wonder how it can happen where it can't in reality.
For final and variable inits I don't like commits with that cause it moves the code in general and make comparisons between versions/revisions hard (don't care much about inline "final" addition but care if you need to change line numbers for that). Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber <http://www.tomitribe.com> 2016-03-11 19:33 GMT+01:00 Andy Gumbrecht <[email protected]>: > Nothing to do with formatting. The goal is to get the intellij green tick > on files rather than red or orange. Trivial global things like finals, 'may > produce nullpointer' and variable inits etc. > > > On 11/03/2016 18:53, Romain Manni-Bucau wrote: > > Hi Andy, > > what's the goal? Thought we finished with any cleanup and decided to not > do it anymore last year. > > > Romain Manni-Bucau > @rmannibucau <https://twitter.com/rmannibucau> | Blog > <http://rmannibucau.wordpress.com> | Github > <https://github.com/rmannibucau> | LinkedIn > <https://www.linkedin.com/in/rmannibucau> | Tomitriber > <http://www.tomitribe.com> > > 2016-03-11 18:48 GMT+01:00 Andy Gumbrecht <[email protected]>: > >> I would like to run a project wide intellij driven cleanup. No fixes, >> just a big cleanup across the board. >> It'll be one big commit. >> >> Any objections? >> >> -- >> Andy Gumbrecht >> https://twitter.com/AndyGeeDe >> http://www.tomitribe.com >> >> > > -- > Andy Gumbrecht > https://twitter.com/AndyGeeDe > http://www.tomitribe.com > >
