I counted +1's from Jonathan, Andy and Romain (Commiters). And also +1's for Thomas and Daniel (Contributors).
Looks like a win :) On Tue, Jul 11, 2017 at 10:19 AM, Andy Gumbrecht <agumbre...@tomitribe.com> wrote: > But if everyone is happy then I'd be happy for it to be pushed. Tested on > my local box last night and it looks great. > > On 11 July 2017 at 15:18, Andy Gumbrecht <agumbre...@tomitribe.com> wrote: > > > I was going to put it up for a vote tonight. > > > > On 11 July 2017 at 14:40, Jonathan Gallimore < > jonathan.gallim...@gmail.com > > > wrote: > > > >> I'm happy to merge it if there are no objections. > >> > >> Jon > >> > >> On Tue, Jul 11, 2017 at 1:36 PM, Ivan Junckes Filho < > >> ivanjunc...@gmail.com> > >> wrote: > >> > >> > Do we have any objections to this change? If no, can somebody merge > it? > >> > > >> > On Sat, Jul 8, 2017 at 5:19 PM, Romain Manni-Bucau < > >> rmannibu...@gmail.com> > >> > wrote: > >> > > >> > > +1 > >> > > > >> > > Le 8 juil. 2017 19:53, "Ivan Junckes Filho" <ivanjunc...@gmail.com> > a > >> > > écrit : > >> > > > >> > > > Hello TomEE devs, I fixed the 404 issue. > >> > > > > >> > > > https://ivanjunckes.github.io/admin > >> > > > https://ivanjunckes.github.io/developers > >> > > > https://ivanjunckes.github.io/advanced > >> > > > > >> > > > How can we proceed from here? Can we get this change merged? > >> > > > > >> > > > On Thu, Jul 6, 2017 at 12:39 PM, Romain Manni-Bucau < > >> > > rmannibu...@gmail.com > >> > > > > > >> > > > wrote: > >> > > > > >> > > > > Not a big fan of "list sites" cause basically you dont find > >> anything > >> > > (or > >> > > > it > >> > > > > is faster to find it in code). Arquillian one is way better IMO. > >> > > > > > >> > > > > Le 6 juil. 2017 17:15, "Andy Gumbrecht" < > agumbre...@tomitribe.com> > >> a > >> > > > > écrit : > >> > > > > > >> > > > > > Just out of interest, what is everyone's favourite OSS > website? > >> I > >> > > > really > >> > > > > > like http://projects.spring.io/spring-boot/ and > >> > https://fabric8.io/ > >> > > > > > > >> > > > > > On 6 July 2017 at 15:58, Andy Gumbrecht < > >> agumbre...@tomitribe.com> > >> > > > > wrote: > >> > > > > > > >> > > > > > > +1 to go to the user list and maybe get some feedback before > >> > > pushing, > >> > > > > but > >> > > > > > > also.. > >> > > > > > > > >> > > > > > > +1 to push it as is - Looks really good Ivan, so thank you > >> very > >> > > much > >> > > > > for > >> > > > > > > the hard work, and working together on the hosting for > review > >> > > issues. > >> > > > > > Thank > >> > > > > > > you Romain for getting the code set up on GitHub. That makes > >> > > reviews > >> > > > > much > >> > > > > > > more transparent! > >> > > > > > > > >> > > > > > > +1 for continuing to improve the 404 issues over time. > >> > > > > > > > >> > > > > > > Andy. > >> > > > > > > > >> > > > > > > On 6 July 2017 at 14:46, Daniel Cunha < > daniels...@apache.org> > >> > > wrote: > >> > > > > > > > >> > > > > > >> +1 to post it user@ list. > >> > > > > > >> The users are the real consumers of the website and their > >> > feedback > >> > > > is > >> > > > > > >> really important. > >> > > > > > >> > >> > > > > > >> On Thu, Jul 6, 2017 at 9:38 AM, Jonathan Gallimore < > >> > > > > > >> jonathan.gallim...@gmail.com> wrote: > >> > > > > > >> > >> > > > > > >> > Hi Ivan! > >> > > > > > >> > > >> > > > > > >> > Thanks for the links. My personal view - I prefer the > >> > > > documentation > >> > > > > > >> link, > >> > > > > > >> > but I do like the split of the documentation page into > >> groups. > >> > > The > >> > > > > > >> > advantage here as I see it is all the documentation is > >> linked > >> > in > >> > > > one > >> > > > > > >> place > >> > > > > > >> > - no need to go into 'Developer' and realize its not > there, > >> > and > >> > > > then > >> > > > > > >> check > >> > > > > > >> > 'Admin'. > >> > > > > > >> > > >> > > > > > >> > I also wonder if we should also post this to the users@ > >> list > >> > to > >> > > > see > >> > > > > > if > >> > > > > > >> > there are any preferences there? > >> > > > > > >> > > >> > > > > > >> > I understand Romain's points about the 404 (see the PR > >> > comments) > >> > > > - a > >> > > > > > >> > potential compromise there is for the admin and developer > >> > links > >> > > to > >> > > > > > >> forward > >> > > > > > >> > onto the documentation page with a note saying its moved > >> and > >> > > > "please > >> > > > > > >> update > >> > > > > > >> > your bookmarks". We'll inevitably want to move content > >> around > >> > > > and/or > >> > > > > > >> change > >> > > > > > >> > the structure over time. Some sort of graceful way of > doing > >> > that > >> > > > > like > >> > > > > > I > >> > > > > > >> > described might be good pattern to follow. > >> > > > > > >> > > >> > > > > > >> > Thanks for taking the time to hack on this and present it > >> to > >> > the > >> > > > > > >> community! > >> > > > > > >> > > >> > > > > > >> > Jon > >> > > > > > >> > > >> > > > > > >> > On Thu, Jul 6, 2017 at 1:30 PM, Ivan Junckes Filho < > >> > > > > > >> ivanjunc...@gmail.com> > >> > > > > > >> > wrote: > >> > > > > > >> > > >> > > > > > >> > > (Please disregard the previous email, pressed enter by > >> > > mistake) > >> > > > > > >> > > > >> > > > > > >> > > Hi guys, thank you for the feedback on this. The > >> intention > >> > of > >> > > > the > >> > > > > > >> > > "Documentation" was to let the user know exactly where > >> what > >> > he > >> > > > is > >> > > > > > >> looking > >> > > > > > >> > > for is. The content inside is not perfect, but we are > >> > getting > >> > > > > > better. > >> > > > > > >> > > > >> > > > > > >> > > The links for the changes made are below, please give > >> > feedback > >> > > > on > >> > > > > > >> them. > >> > > > > > >> > > > >> > > > > > >> > > Pull Request: > >> > > > > > >> > > https://github.com/apache/tomee-site-generator/pull/1 > >> > > > > > >> > > > >> > > > > > >> > > Website for review: > >> > > > > > >> > > https://ivanjunckes.github.io/ > >> > > > > > >> > > > >> > > > > > >> > > Thank you. > >> > > > > > >> > > > >> > > > > > >> > > > >> > > > > > >> > > On Thu, Jul 6, 2017 at 9:27 AM, Ivan Junckes Filho < > >> > > > > > >> > ivanjunc...@gmail.com> > >> > > > > > >> > > wrote: > >> > > > > > >> > > > >> > > > > > >> > > > Hi guys, thank you for the feedback on this. The > >> intention > >> > > of > >> > > > > the > >> > > > > > >> > > > "Documentation" was to let the user know exactly > where > >> > what > >> > > he > >> > > > > is > >> > > > > > >> > looking > >> > > > > > >> > > > for is. The content inside is not perfect, but we are > >> > > getting > >> > > > > > >> better. > >> > > > > > >> > > > > >> > > > > > >> > > > Here are all the changes made > >> > > > > > >> > > > > >> > > > > > >> > > > > >> > > > > > >> > > > On Wed, Jul 5, 2017 at 7:51 PM, Romain Manni-Bucau < > >> > > > > > >> > > rmannibu...@gmail.com> > >> > > > > > >> > > > wrote: > >> > > > > > >> > > > > >> > > > > > >> > > >> Ok, saw Andy did a similar comment on github so > >> probably > >> > > > let's > >> > > > > > >> reverse > >> > > > > > >> > > the > >> > > > > > >> > > >> question. > >> > > > > > >> > > >> > >> > > > > > >> > > >> Anyone feeling like me it is a passthrough? (if not > >> > under 1 > >> > > > day > >> > > > > > >> think > >> > > > > > >> > we > >> > > > > > >> > > >> can "close it" and just push it in prod) > >> > > > > > >> > > >> > >> > > > > > >> > > >> > >> > > > > > >> > > >> Romain Manni-Bucau > >> > > > > > >> > > >> @rmannibucau <https://twitter.com/rmannibucau> | > >> Blog > >> > > > > > >> > > >> <https://blog-rmannibucau.rhcloud.com> | Old Blog > >> > > > > > >> > > >> <http://rmannibucau.wordpress.com> | Github < > >> > > > > > >> > > >> https://github.com/rmannibucau> | > >> > > > > > >> > > >> LinkedIn <https://www.linkedin.com/in/rmannibucau> > | > >> > > JavaEE > >> > > > > > >> Factory > >> > > > > > >> > > >> <https://javaeefactory-rmannibucau.rhcloud.com> > >> > > > > > >> > > >> > >> > > > > > >> > > >> 2017-07-06 0:48 GMT+02:00 Thomas Whitmore > >> > > > > > >> <twhitmore@bravurasolutions. > >> > > > > > >> > > com > >> > > > > > >> > > >> >: > >> > > > > > >> > > >> > >> > > > > > >> > > >> > For me the Documentation menu item is very good; > it > >> > > shows > >> > > > at > >> > > > > > the > >> > > > > > >> > top > >> > > > > > >> > > >> > level that the TomEE project has documentation. > >> > > > > > >> > > >> > Also like the content of the Documentation page, > it > >> > hits > >> > > > 'How > >> > > > > > to > >> > > > > > >> > > >> > Configure', 'IDEs' and 'Testing' upfront & early > >> which > >> > > > > should > >> > > > > > >> give > >> > > > > > >> > a > >> > > > > > >> > > >> good > >> > > > > > >> > > >> > impression on people considering uptake of the > >> project > >> > -- > >> > > > as > >> > > > > > >> well as > >> > > > > > >> > > not > >> > > > > > >> > > >> > looking so terribly empty. > >> > > > > > >> > > >> > > >> > > > > > >> > > >> > +1 on both fronts. > >> > > > > > >> > > >> > > >> > > > > > >> > > >> > Search can be an additional feature but for me > >> getting > >> > > the > >> > > > > > static > >> > > > > > >> > text > >> > > > > > >> > > >> > structure OK is paramount. I think Ivan has made > >> very > >> > > good > >> > > > > > >> > improvement > >> > > > > > >> > > >> on > >> > > > > > >> > > >> > that. > >> > > > > > >> > > >> > > >> > > > > > >> > > >> > > >> > > > > > >> > > >> > -----Original Message----- > >> > > > > > >> > > >> > From: Romain Manni-Bucau [mailto: > >> rmannibu...@gmail.com > >> > ] > >> > > > > > >> > > >> > Sent: Thursday, 6 July 2017 9:09 AM > >> > > > > > >> > > >> > To: dev@tomee.apache.org > >> > > > > > >> > > >> > Subject: Re: Site and "documentation" usage > >> > > > > > >> > > >> > > >> > > > > > >> > > >> > very close http://people.apache.org/~rman > >> nibucau/ivan/ > >> > > can > >> > > > > be > >> > > > > > >> used > >> > > > > > >> > > >> (think > >> > > > > > >> > > >> > Ivan did some minor adjustments after but overall > >> idea > >> > is > >> > > > > here > >> > > > > > if > >> > > > > > >> > I'm > >> > > > > > >> > > >> not > >> > > > > > >> > > >> > mistaken) > >> > > > > > >> > > >> > > >> > > > > > >> > > >> > > >> > > > > > >> > > >> > Romain Manni-Bucau > >> > > > > > >> > > >> > @rmannibucau <https://twitter.com/rmannibucau> | > >> > Blog < > >> > > > > > >> > > >> > https://blog-rmannibucau.rhcloud.com> | Old Blog > < > >> > > > > > >> > > >> > http://rmannibucau.wordpress.com> | Github < > >> > > > > > >> > > >> https://github.com/rmannibucau> > >> > > > > > >> > > >> > | LinkedIn <https://www.linkedin.com/in/ > rmannibucau> > >> | > >> > > > > JavaEE > >> > > > > > >> > > Factory < > >> > > > > > >> > > >> > https://javaeefactory-rmannibucau.rhcloud.com> > >> > > > > > >> > > >> > > >> > > > > > >> > > >> > 2017-07-05 23:03 GMT+02:00 Jonathan Gallimore < > >> > > > > > >> > > >> > jonathan.gallim...@gmail.com> > >> > > > > > >> > > >> > : > >> > > > > > >> > > >> > > >> > > > > > >> > > >> > > Ivan - did you have some luck getting that > staged > >> > > > > somewhere? > >> > > > > > >> I'd > >> > > > > > >> > > love > >> > > > > > >> > > >> > > to take a look and give some feedback. > >> > > > > > >> > > >> > > > >> > > > > > >> > > >> > > Cheers > >> > > > > > >> > > >> > > > >> > > > > > >> > > >> > > Jon > >> > > > > > >> > > >> > > >> > > > > > >> > > >> > ______________________________ > >> > > > ______________________________ > >> > > > > > >> > > __________ > >> > > > > > >> > > >> > This email has been scanned by the Symantec Email > >> > > > > > Security.cloud > >> > > > > > >> > > >> service. > >> > > > > > >> > > >> > For more information please visit > >> > > > > http://www.symanteccloud.com > >> > > > > > >> > > >> > ______________________________ > >> > > > ______________________________ > >> > > > > > >> > > __________ > >> > > > > > >> > > >> > > >> > > > > > >> > > >> > >> > > > > > >> > > > > >> > > > > > >> > > > > >> > > > > > >> > > > >> > > > > > >> > > >> > > > > > >> > >> > > > > > >> > >> > > > > > >> > >> > > > > > >> -- > >> > > > > > >> Daniel Cunha > >> > > > > > >> https://twitter.com/dvlc_ > >> > > > > > >> > >> > > > > > > > >> > > > > > > > >> > > > > > > > >> > > > > > > -- > >> > > > > > > Andy Gumbrecht > >> > > > > > > https://twitter.com/AndyGeeDe > >> > > > > > > http://www.tomitribe.com > >> > > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > -- > >> > > > > > Andy Gumbrecht > >> > > > > > https://twitter.com/AndyGeeDe > >> > > > > > http://www.tomitribe.com > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > > > > > > > > -- > > Andy Gumbrecht > > https://twitter.com/AndyGeeDe > > http://www.tomitribe.com > > > > > > -- > Andy Gumbrecht > https://twitter.com/AndyGeeDe > http://www.tomitribe.com >
