Hi Jon If we do it this way - jaxrs 2.1 - I d be to PR cxf instead of tomee. We fork too much code to stay sane here.
What about just sorting by priority blindly? Cxf will handle the q and type sorting anyway, no? Le 26 juil. 2017 22:18, "Jonathan Gallimore" <[email protected]> a écrit : > Hi, > > I've had a go at this: https://github.com/apache/tomee/pull/96 > > This creates a default comparator when no setting for > cxf.jaxrs.provider-comparator is specified. This will order by priority > first, but will still incorporate the default CXF sorting where priorities > are the same for backwards compatibility. > > Michel's test case appears to work ok with this patch. > > Any feedback would be most welcome. > > Many thanks > > Jon > > On Tue, Jul 25, 2017 at 5:02 PM, Jonathan Gallimore < > [email protected]> wrote: > > > Yep - that's what I had in my mind. Makes sense if a comparator is > > specified, we should use that instead of the @Priority ordering. > > > > Jon > > > > On Tue, Jul 25, 2017 at 4:59 PM, Romain Manni-Bucau < > [email protected] > > > wrote: > > > >> +1 > >> > >> What's do we want to do? Looks like a EE 8 feature we can eagerly > support > >> as a default comparator (if the comparator is set we must bypass it to > >> respect the comparator IMHO) > >> > >> > >> Romain Manni-Bucau > >> @rmannibucau <https://twitter.com/rmannibucau> | Blog > >> <https://blog-rmannibucau.rhcloud.com> | Old Blog > >> <http://rmannibucau.wordpress.com> | Github < > >> https://github.com/rmannibucau> | > >> LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory > >> <https://javaeefactory-rmannibucau.rhcloud.com> > >> > >> 2017-07-25 17:03 GMT+02:00 Jonathan Gallimore < > >> [email protected]> > >> : > >> > >> > I'm happy to take a look at this one, unless someone else is already > >> > working on it? > >> > > >> > Jon > >> > > >> > > > > >
