Happy to help end of the week if needed. Just dont want we become slow or leaking as a quick fix and forget about it ;).
Le 27 janv. 2018 11:04, "Jonathan Gallimore" <jonathan.gallim...@gmail.com> a écrit : > Reverted. And don't worry, I'll make that build green, or I'll die trying. > > Jon > > On Sat, Jan 27, 2018 at 9:44 AM, Jonathan Gallimore < > jonathan.gallim...@gmail.com> wrote: > > > It's really to see if that affects the single failing test we have in the > > build or not. I'm suspecting not, but the build is passing locally. I > will > > revert. > > > > Jon > > > > On 26 Jan 2018 10:15, "Romain Manni-Bucau" <rmannibu...@gmail.com> > wrote: > > > >> Hi Jon, > >> > >> It is important we work reusing fork otherwise we start a container per > >> test which makes it practically unusable. What's the issue here and why > >> would we need this workaround? > >> > >> > >> Romain Manni-Bucau > >> @rmannibucau <https://twitter.com/rmannibucau> | Blog > >> <https://rmannibucau.metawerx.net/> | Old Blog > >> <http://rmannibucau.wordpress.com> | Github < > >> https://github.com/rmannibucau> | > >> LinkedIn <https://www.linkedin.com/in/rmannibucau> > >> > >> 2018-01-26 11:13 GMT+01:00 <jgallim...@apache.org>: > >> > >> > Repository: tomee > >> > Updated Branches: > >> > refs/heads/master b8bbf50c2 -> 8389beb21 > >> > > >> > > >> > No fork > >> > > >> > > >> > Project: http://git-wip-us.apache.org/repos/asf/tomee/repo > >> > Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/e1dd440c > >> > Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/e1dd440c > >> > Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/e1dd440c > >> > > >> > Branch: refs/heads/master > >> > Commit: e1dd440c8c73cb358830bdbf8858c78cb209affe > >> > Parents: 489b314 > >> > Author: Jonathan Gallimore <j...@jrg.me.uk> > >> > Authored: Tue Jan 23 20:40:22 2018 +0000 > >> > Committer: Jonathan Gallimore <j...@jrg.me.uk> > >> > Committed: Tue Jan 23 20:40:22 2018 +0000 > >> > > >> > ------------------------------------------------------------ > ---------- > >> > arquillian/arquillian-tomee-tests/pom.xml | 26 > >> +++++++++++++------------- > >> > 1 file changed, 13 insertions(+), 13 deletions(-) > >> > ------------------------------------------------------------ > ---------- > >> > > >> > > >> > http://git-wip-us.apache.org/repos/asf/tomee/blob/e1dd440c/ > >> > arquillian/arquillian-tomee-tests/pom.xml > >> > ------------------------------------------------------------ > ---------- > >> > diff --git a/arquillian/arquillian-tomee-tests/pom.xml > >> > b/arquillian/arquillian-tomee-tests/pom.xml > >> > index e1ef145..77bb606 100644 > >> > --- a/arquillian/arquillian-tomee-tests/pom.xml > >> > +++ b/arquillian/arquillian-tomee-tests/pom.xml > >> > @@ -1,25 +1,25 @@ > >> > <?xml version="1.0"?> > >> > -<!-- Licensed to the Apache Software Foundation (ASF) under one or > more > >> > contributor > >> > - license agreements. See the NOTICE file distributed with this work > >> for > >> > additional > >> > - information regarding copyright ownership. The ASF licenses this > >> file to > >> > - You under the Apache License, Version 2.0 (the "License"); you may > >> not > >> > use > >> > - this file except in compliance with the License. You may obtain a > >> copy > >> > of > >> > - the License at http://www.apache.org/licenses/LICENSE-2.0 Unless > >> > required > >> > - by applicable law or agreed to in writing, software distributed > under > >> > the > >> > - License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR > >> > CONDITIONS > >> > - OF ANY KIND, either express or implied. See the License for the > >> specific > >> > +<!-- Licensed to the Apache Software Foundation (ASF) under one or > more > >> > contributor > >> > + license agreements. See the NOTICE file distributed with this work > >> for > >> > additional > >> > + information regarding copyright ownership. The ASF licenses this > >> file to > >> > + You under the Apache License, Version 2.0 (the "License"); you may > >> not > >> > use > >> > + this file except in compliance with the License. You may obtain a > >> copy > >> > of > >> > + the License at http://www.apache.org/licenses/LICENSE-2.0 Unless > >> > required > >> > + by applicable law or agreed to in writing, software distributed > under > >> > the > >> > + License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR > >> > CONDITIONS > >> > + OF ANY KIND, either express or implied. See the License for the > >> specific > >> > language governing permissions and limitations under the License. > --> > >> > <project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi=" > >> > http://www.w3.org/2001/XMLSchema-instance"; > >> > xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 > >> > http://maven.apache.org/xsd/maven-4.0.0.xsd";> > >> > - > >> > + > >> > <modelVersion>4.0.0</modelVersion> > >> > - > >> > + > >> > <parent> > >> > <artifactId>arquillian</artifactId> > >> > <groupId>org.apache.tomee</groupId> > >> > <version>7.0.5-SNAPSHOT</version> > >> > </parent> > >> > - > >> > + > >> > <artifactId>arquillian-tomee-tests</artifactId> > >> > <packaging>pom</packaging> > >> > > >> > @@ -173,7 +173,7 @@ > >> > <skip>true</skip> > >> > <parallel>none</parallel> > >> > <threadCount>1</threadCount> > >> > - <reuseForks>true</reuseForks> > >> > + <reuseForks>false</reuseForks> > >> > </configuration> > >> > </plugin> > >> > </plugins> > >> > > >> > > >> > > >
