Hi Mark ++1 for this. Examples must not be a test suite, and it is a great idea to separate them from the main source code. It must be independently build and execute from main TomEE codebase. Best Gurkan
On Wed, Jun 27, 2018 at 9:48 AM, Mark Struberg <[email protected]> wrote: > Hi folks! > > While trying to release TomEE-7.0.5 I figured that the Examples as part of > the TomEE core project are really counter productive. > > * they break the maven-release-plugin, because they don't use the same > version > * They pollute the build (samples alone take 15 minutes of our build), > which might lower contributions > * They are bound to a specific tomee version, so they cannot easily be > tested against another version > * We have many people who want to probably add samples without wanting to > go through all the hassle to build full tomee > > Of course there are also downsides, mainly: > * by having the samples as part of our build we also have improved test > coverage. > > Well, since right now almost nobody runs the tests when building TomEE > (but instead rely on our CI, because it takes so long) it makes no > difference anyway. I'd rather have a core project with decently good test > coverage - and people also run it - than having a bit better coverage > which nobody runs. > > So I propose to move the Examples to a separate repo and add a separate CI > for it. > Of course we should look at how to set it up so we can have samples for > multiple EE versions. > > wdyt? > > LieGrue, > strub > >
