Hi tx Mark! Yeah, the problem is not much the swagger thing, but more the injection of the Application object. Swagger was just on use case that I was working on for this potential user, so I thought it would be great to have it in our examples.
>> Imo it's an absolute showstopper to use swagger in ANY project - not in OSS, and even less so in commercial projects! Good to know! I will bring that up next time this comes around in our (new user and I) discussions. tx! []s, Thiago. On Fri, Jul 13, 2018 at 3:53 PM, Mark Struberg <[email protected]> wrote: > -1 (binding) for adding that swagger-api. > > I did download the jar and it's sources and there are tons of classes with > no license header. > The jar has no license info in it's manifest, contains no LICENSE, no > NOTICE, etc. > > What the fiddlesticks ^^ > Can someone else please take a look at those jars? > Imo it's an absolute showstopper to use swagger in ANY project - not in > OSS, and even less so in commercial projects! > > Again: please also review it and point me to the license files. > > LieGrue, > strub > > > > Am 13.07.2018 um 21:11 schrieb Jonathan Gallimore < > [email protected]>: > > > > I'm ok with it, no need to apologize to me. I'd push back if there > wasn't a > > patch :). If folks are happy to re-review and retest, I'm ok to re-roll. > > > > Jon > > > > On Fri, 13 Jul 2018, 20:05 Thiago Veronezi, <[email protected]> wrote: > > > >> I know. :/ Sorry. Thats why my 0. That only happens when you do > something > >> like this... > >> > >> @Context > >> Application app; > >> > >> ... which is what the swagger folks do. > >> > >> https://github.com/swagger-api/swagger-core/blob/2.0/ > modules/swagger-jaxrs2/src/main/java/io/swagger/v3/ > jaxrs2/integration/resources/AcceptHeaderOpenApiResource.java > >> > >> I don't think we do that very often, so 0; Although, this would help me > a > >> lot on selling TomEE to a current potential user... but that's my > problem. > >> :) > >> > >> []s, > >> Thiago. > >> > >> > >> > >> > >> > >> On Fri, Jul 13, 2018 at 2:55 PM, Jonathan Gallimore < > >> [email protected]> wrote: > >> > >>> Thanks for the patch and the review! > >>> > >>> I'll defer to the community on this one. I'm ok to re-roll, but will > >> point > >>> out we're 10 days since the first roll, and we'd be resetting the > counter > >>> again. > >>> > >>> Jon > >>> > >>> On Fri, 13 Jul 2018, 19:36 Thiago Veronezi, <[email protected]> > wrote: > >>> > >>>> Hi guys, > >>>> > >>>> Sorry for being late. I had other things to care lately. I've finally > >> got > >>>> time for this. I hope it's not too late, or not too bad of a problem. > >>>> I've got a NPE when creating a swagger example. It's very simple to > >>>> reproduce. Simply create a jaxrs application and include... > >>>> > >>>> <dependency> > >>>> <groupId>io.swagger.core.v3</groupId> > >>>> <artifactId>swagger-jaxrs2</artifactId> > >>>> <version>2.0.1</version> > >>>> </dependency> > >>>> > >>>> This is supposed to give you the /openapi.json and /openapi.yaml > >>> endpoints. > >>>> In our case it gives NPE. I've created this PR which fixes it and adds > >>> the > >>>> swagger example. > >>>> > >>>> My vote is 0 if you find it's OK to have this until next version. If > >>> there > >>>> is another way to fix/workaround this without code change, that would > >> be > >>>> even better. > >>>> > >>>> https://github.com/apache/tomee/pull/134 > >>>> > >>>> []s, > >>>> Thiago. > >>>> > >>>> > >>>> > >>>> > >>>> > >>>> On Fri, Jul 13, 2018 at 7:29 AM, Alex The Rocker < > [email protected] > >>> > >>>> wrote: > >>>> > >>>>> Hello, > >>>>> > >>>>> Yes Thank you very much Jon for the great TomEE release work! > >>>>> I confirm what you wrote. > >>>>> Better release 7.0.5 with everything that works. > >>>>> Hope to see later a 7.0.6 supporting Java 11 ! > >>>>> > >>>>> Alex > >>>>> > >>>>> 2018-07-12 12:24 GMT+02:00 Jonathan Gallimore < > >>>>> [email protected]>: > >>>>>> I currently have: > >>>>>> > >>>>>> 1 +1 for the release as it is (Romain) > >>>>>> 3 requests for a release with Tomcat 8.5.31 (Gurkan, Felipe, and > >> Alex > >>>>> (Alex > >>>>>> replied to me directly)) > >>>>>> > >>>>>> Is anyone -1 for a TomEE 7.0.5 release built on Tomcat 8.5.31? > >> Please > >>>>> speak > >>>>>> up now if you do object so we can talk about it more on the list > >>> here. > >>>>> From > >>>>>> my own perspective, I'm ok with the release as it is, and I'd also > >>> +1 a > >>>>>> 7.0.5 release with Tomcat 8.5.31 provided it didn't have other > >>> issues. > >>>>>> > >>>>>> I'll look to re-roll the release again later today, unless someone > >>>>> objects. > >>>>>> > >>>>>> Many thanks everyone. > >>>>>> > >>>>>> Jon > >>>>>> > >>>>>> On Wed, Jul 11, 2018 at 1:17 AM, Gurkan Erdogdu < > >> [email protected] > >>>> > >>>>> wrote: > >>>>>> > >>>>>>> Hi Jon > >>>>>>> Thanks for initiating this. > >>>>>>> I opened a bug in Tomcat regarding java:/ namespace and it will be > >>>>>>> corrected in 8.5.33 and upper versions. If we distribute the TomEE > >>>> with > >>>>>>> 8.5.32, it will be a problem for users who uses lookups with > >>> openejb. > >>>>> So, > >>>>>>> for this release we can stick to 8.5.31. WDYT? > >>>>>>> Regards. > >>>>>>> Gurkan > >>>>>>> > >>>>>>> > >>>>>>> On Tue, Jul 10, 2018 at 9:26 PM, Jonathan Gallimore < > >>>>>>> [email protected]> wrote: > >>>>>>> > >>>>>>>> Hi Everyone, > >>>>>>>> > >>>>>>>> Here is the second roll of TomEE 7.0.5. Please can you take a > >> look > >>>> and > >>>>>>>> vote? Everyone, committer or not, is encouraged to test and > >> vote. > >>>>>>>> > >>>>>>>> Staging repo: > >>>>>>>> https://repository.apache.org/content/repositories/ > >>>>> orgapachetomee-1115 > >>>>>>>> > >>>>>>>> Source zip: > >>>>>>>> https://repository.apache.org/content/repositories/ > >>>>>>>> orgapachetomee-1115/org/apache/tomee/tomee-project/7. > >>>>>>>> 0.5/tomee-project-7.0.5-source-release.zip > >>>>>>>> > >>>>>>>> Dist area: > >>>>>>>> https://dist.apache.org/repos/dist/dev/tomee/staging-1115/ > >>>>>>>> > >>>>>>>> Legal: > >>>>>>>> https://dist.apache.org/repos/dist/dev/tomee/staging-1115/ > >>> legal.zip > >>>>>>>> > >>>>>>>> Keys: > >>>>>>>> https://dist.apache.org/repos/dist/release/tomee/KEYS > >>>>>>>> > >>>>>>>> Libraries changed since TomEE 7.0.4: > >>>>>>>> > >>>>>>>> Tomcat => 8.5.32 > >>>>>>>> CXF => 3.1.15 > >>>>>>>> Johnzon => 1.0.1 > >>>>>>>> OWB => 1.7.5 > >>>>>>>> XBean => 4.9 > >>>>>>>> XmlSchema core => 2.2.3 > >>>>>>>> OpenJPA => 2.4.3 > >>>>>>>> > >>>>>>>> Changes since the last roll: > >>>>>>>> > >>>>>>>> - Remove javax.xml.soap-api-1.3.5.jar library which was > >>> incorrectly > >>>>>>>> included > >>>>>>>> - Update to Tomcat 8.5.32 > >>>>>>>> - Change JNDI name used for datasource in CDI TCK test to use an > >>>>>>> equivalent > >>>>>>>> name under the java: namespace > >>>>>>>> > >>>>>>>> Changelog: > >>>>>>>> https://issues.apache.org/jira/browse/TOMEE-2175?jql=project > >>>>>>>> %20%3D%20TOMEE%20AND%20(status%20%3D%20Resolved%20OR%20statu > >>>>>>>> s%20%3D%20CLOSED)%20AND%20fixVersion%20%3D%207.0.5%20O > >>>>>>>> RDER%20BY%20priority%20DESC%2C%20updated%20DESC > >>>>>>>> > >>>>>>>> (If anyone knows a better way to get that list, let me know ;-) > >> ) > >>>>>>>> > >>>>>>>> Please vote: > >>>>>>>> +1: Release > >>>>>>>> -1 Do not release because ... > >>>>>>>> > >>>>>>>> The vote will be open for 3 days or the consensus is binding (At > >>>>> least 3 > >>>>>>>> binding votes). > >>>>>>>> > >>>>>>>> Many thanks > >>>>>>>> > >>>>>>>> Jon > >>>>>>>> > >>>>>>> > >>>>> > >>>> > >>> > >> > >
