Hi Jon, I didn't mean to trigger such big debate : I was just asking a question about Java 11 support with 7.1.0, but again my current focus is 7.0.6, so yes, a future 7.1.x including Java 11 support sounds good (non-binding)
Alexandre Le lun. 3 sept. 2018 à 21:52, Jonathan Gallimore <[email protected]> a écrit : > > Are there any further thoughts on this? I actually kept my work from > yesterday, so if we're happy to continue, I could finish that and put it up > for a vote. > > Alexandre - if we followed up in a couple of weeks with 7.1.1 that pulled > in the necessary J11 patches, would that work for you? > > On Mon, Sep 3, 2018 at 11:45 AM Roberto Cortez <[email protected]> > wrote: > > > I do agree that when a release is under way the amount of changes should > > be limited to the issues preventing that release. Of course, that doesn’t > > mean we couldn't include something that we find useful, but I do think it > > is useful that we work with a known baseline, so we know what we are > > testing. Testing was done with the current binaries and while I believe the > > additional PR’s are fine, we never know what is going to happen and they > > may introduce additional issues (I’m pretty sure everyone already > > experience this :) ). > > > > I think this could be improved if we released more often and periodically. > > In that way, people would know. Ok, I didn’t got my fix this week. It’s > > fine, I will have it in the next release. > > > > We had an email a couple of weeks ago with a proposal to move to a fixed > > release schedule. I think we should start working toward that goal. > > > > Cheers, > > Roberto > > > > > On 2 Sep 2018, at 23:04, Jonathan Gallimore < > > [email protected]> wrote: > > > > > > I understand, and I apologize for the confusion. 7.0.x, 7.1.x and 8.0.x > > are > > > effectively all moving forward in parallel. We also backport stuff to > > 1.7.x > > > so there's a lot to keep track of. Indeed, including that patch in 7.0.6 > > is > > > reasonable, and I'd expect it to be ported to 7.1.1 as well. The > > > minor.minor version is a little out of step, and I agree its a little > > > confusing that support for Java versions in 7.0.6 might be better than > > > 7.1.0. I suspect that in time, one of the branches will disappear, or > > we'll > > > start releasing in parallel, which may make life easier. > > > > > > For clarity, this release is to get MicroProfile in TomEE released. Its > > > essentially 7.0.5 with MicroProfile. > > > > > > I do apologize if came off short in the last message - your question is a > > > very reasonable question, and I'm glad you asked it - I'm sure others had > > > the same question. As the person currently rolling the releases, my > > > preference is re-rolls are just for release issues (like the legal issue > > I > > > spotted), and not "oh wait, can you include this too". Folks already > > > invested time reviewing these binaries, so the fewer changes in re-rolls, > > > the easier the re-review is. If we get good at releasing (and there is no > > > reason why we can't), waiting a couple of weeks for the next release > > won't > > > be too bad. I apologize if you took my feedback personally, that wasn't > > the > > > intention. We're starting to make progress with releasing more often, and > > > we should keep going. I'm just trying to keep the momentum going as best > > as > > > I can, and I worry that we'll get more PRs requested that will push us > > back > > > from releasing. > > > > > > Jon > > > > > > On Sun, Sep 2, 2018 at 10:43 PM Alex The Rocker <[email protected]> > > > wrote: > > > > > >> Hi Jon, > > >> > > >> It was just a question. > > >> Java 11 support will be more important for me in TomEE 7.0.6 (current > > >> snapshot was OK for by first tests, I'll have more feedbacks starting > > >> this week), but I find puzzling that TomEE 7.1 could support less Java > > >> versions than future 7.0.6. > > >> > > >> Maybe it's just me :) > > >> > > >> Alexandre > > >> > > >> Le dim. 2 sept. 2018 à 23:35, Jonathan Gallimore > > >> <[email protected]> a écrit : > > >>> > > >>> I can re-roll it to include this, but as I write this, the maven > > >>> release:perform literally just completed. For visibility, going as fast > > >> as > > >>> I can, its a good 2 hours each time I do this. > > >>> > > >>> The release has been open for comment for a few days, and prior to > > that I > > >>> put up a preview release which didn't get much feedback. Prior to > > that, I > > >>> posted saying we were going to do the release - so there was > > opportunity > > >> to > > >>> discuss the content of the release. I'm going to drop and rollback the > > >>> release and wait 24-48 hours before starting again to allow the > > community > > >>> to discuss where to go from here. > > >>> > > >>> Can you confirm that 7.1.0 works with Java 11 with this patch? > > Certainly > > >> it > > >>> looked like other dependencies needed update and hadn't finished my own > > >>> testing. I merged that PR in as it moved us forward. > > >>> > > >>> While I appreciate the importance of the Java 11 support to you - this > > >> was > > >>> only supposed to be a simple re-roll to correct a legal issue. Now we > > >> have > > >>> multiple other changes going in. We all want faster, more rapid > > releases. > > >>> If we keep halting releases to slip in more patches, I suspect keeping > > up > > >>> release cadence will be hard, and I'll personally probably end up > > >> spending > > >>> more time rolling releases than actually fixing issues. My preference > > >> would > > >>> be to keep going and simply release far more often with much smaller > > >> deltas. > > >>> > > >>> Hope that makes sense. > > >>> > > >>> Jon > > >>> > > >>> On Sun, Sep 2, 2018 at 10:12 PM Alex The Rocker <[email protected]> > > >>> wrote: > > >>> > > >>>> Hello Jon, > > >>>> > > >>>> Any reason why TomEE 7.1 wouldn't include the PR proposed in this JIRA > > >>>> https://issues.apache.org/jira/browse/TOMEE-2200 to make it > > compatible > > >>>> with Java 11 (which will be officially be released this month) ? > > >>>> > > >>>> Thanks, > > >>>> Alexandre > > >>>> > > >>>> Le dim. 2 sept. 2018 à 22:14, Jonathan Gallimore > > >>>> <[email protected]> a écrit : > > >>>>> > > >>>>> Rerolling with Roberto's corrected NOTICE file. I'm including > > >> Thiago's > > >>>>> commit as well. I'll post a new VOTE. > > >>>>> > > >>>>> Jon > > >>>>> > > >>>>> On Sun, Sep 2, 2018 at 7:44 PM Jean-Louis Monteiro < > > >>>> [email protected]> > > >>>>> wrote: > > >>>>> > > >>>>>> A full reroll is usually faster. > > >>>>>> > > >>>>>> Le ven. 31 août 2018 à 23:49, Roberto Cortez > > >>>> <[email protected]> > > >>>>>> a écrit : > > >>>>>> > > >>>>>>> Ok, I’ve figured out the NOTICE file issue. > > >>>>>>> > > >>>>>>> Apparently, we have duplicate places where we need to place the > > >>>> files. > > >>>>>> One > > >>>>>>> in the webapp module and another one in the dist module :( > > >>>>>>> > > >>>>>>> Here is a PR to fix the issue: > > >>>>>>> https://github.com/apache/tomee/pull/158 < > > >>>>>>> https://github.com/apache/tomee/pull/158> > > >>>>>>> > > >>>>>>> I would suggest that instead of a full reroll, we update the TAG > > >> with > > >>>>>> this > > >>>>>>> change and redeploy only the MP dist binary. Not sure if this is > > >>>> allowed > > >>>>>> :) > > >>>>>>> > > >>>>>>> Cheers, > > >>>>>>> Roberto > > >>>>>>> > > >>>>>>>> On 31 Aug 2018, at 22:31, Roberto Cortez > > >>>> <[email protected]> > > >>>>>>> wrote: > > >>>>>>>> > > >>>>>>>> I was writing some MP sample app cases that we can use. > > >>>>>>>> > > >>>>>>>> Or are you referring to something else? > > >>>>>>>> > > >>>>>>>> > > >>>>>>>>> On 31 Aug 2018, at 16:00, Jonathan Gallimore < > > >>>>>>> [email protected]> wrote: > > >>>>>>>>> > > >>>>>>>>> Roberto - did you have a test/sample app for this? > > >>>>>>>>> > > >>>>>>>>> Looks like the microprofile zip is short of a NOTICE file, and > > >>>> that > > >>>>>>> would > > >>>>>>>>> need to include the same notices as webprofile, plus this one: > > >>>>>>>>> > > >>>>>>>>> ( > > >>>>>>>>> > > >>>>>>> > > >>>>>> > > >>>> > > >> > > https://bitbucket.org/b_c/jose4j/src/7f9624414a1baf752adbc61d4a1be16253eeec23/NOTICE.txt?at=master&fileviewer=file-view-default > > >>>>>>>>> ) > > >>>>>>>>> ----- > > >>>>>>>>> jose4j > > >>>>>>>>> Copyright 2012-2015 Brian Campbell > > >>>>>>>>> > > >>>>>>>>> EcdsaUsingShaAlgorithm contains code for converting the > > >>>> concatenated > > >>>>>>>>> R & S values of the signature to and from DER, which was > > >>>> originally > > >>>>>>>>> derived from the Apache Santuario XML Security library's > > >>>>>> SignatureECDSA > > >>>>>>>>> implementation. http://santuario.apache.org/ > > >>>>>>>>> > > >>>>>>>>> The Base64 implementation in this software was derived from > > >> the > > >>>>>>>>> Apache Commons Codec project. > > >>>>>>>>> http://commons.apache.org/proper/commons-codec/ > > >>>>>>>>> > > >>>>>>>>> JSON processing in this software was derived from the > > >> JSON.simple > > >>>>>>> toolkit. > > >>>>>>>>> https://code.google.com/p/json-simple/ > > >>>>>>>>> ----- > > >>>>>>>>> > > >>>>>>>>> Thoughts? > > >>>>>>>>> > > >>>>>>>>> Other than that I can't see any issues. > > >>>>>>>>> > > >>>>>>>>> Jon > > >>>>>>>>> > > >>>>>>>>> > > >>>>>>>>> On Fri, Aug 31, 2018 at 2:39 PM Jean-Louis Monteiro < > > >>>>>>>>> [email protected]> wrote: > > >>>>>>>>> > > >>>>>>>>>> +1 > > >>>>>>>>>> > > >>>>>>>>>> Thank you very much Jon for the release and Roberto for the > > >>>>>>> microprofile > > >>>>>>>>>> work > > >>>>>>>>>> > > >>>>>>>>>> -- > > >>>>>>>>>> Jean-Louis Monteiro > > >>>>>>>>>> http://twitter.com/jlouismonteiro > > >>>>>>>>>> http://www.tomitribe.com > > >>>>>>>>>> > > >>>>>>>>>> On Fri, Aug 31, 2018 at 1:33 PM, Mark Struberg > > >>>>>>> <[email protected]> > > >>>>>>>>>> wrote: > > >>>>>>>>>> > > >>>>>>>>>>> +1 > > >>>>>>>>>>> > > >>>>>>>>>>> LieGrue, > > >>>>>>>>>>> strub > > >>>>>>>>>>> > > >>>>>>>>>>> > > >>>>>>>>>>>> Am 30.08.2018 um 12:24 schrieb Jonathan Gallimore < > > >>>>>>>>>>> [email protected]>: > > >>>>>>>>>>>> > > >>>>>>>>>>>> Hi Everyone, > > >>>>>>>>>>>> > > >>>>>>>>>>>> Here is the first roll of TomEE 7.1.0. Please can you take > > >> a > > >>>> look > > >>>>>> and > > >>>>>>>>>>>> vote? Everyone, > > >>>>>>>>>>>> committer or not, is encouraged to test and vote. > > >>>>>>>>>>>> > > >>>>>>>>>>>> Staging repo: > > >>>>>>>>>>>> > > >>>>>>> > > >>>> > > https://repository.apache.org/content/repositories/orgapachetomee-1119 > > >>>>>>>>>>>> > > >>>>>>>>>>>> Source zip: > > >>>>>>>>>>>> https://repository.apache.org/content/repositories/ > > >>>>>>>>>>> orgapachetomee-1119/org/apache/tomee/tomee-project/7. > > >>>>>>>>>>> 1.0/tomee-project-7.1.0-source-release.zip > > >>>>>>>>>>>> > > >>>>>>>>>>>> Dist area: > > >>>>>>>>>>>> https://dist.apache.org/repos/dist/dev/tomee/staging-1119/ > > >>>>>>>>>>>> > > >>>>>>>>>>>> Legal: > > >>>>>>>>>>>> > > >>>>>> > > >> https://dist.apache.org/repos/dist/dev/tomee/staging-1119/legal.zip > > >>>>>>>>>>>> > > >>>>>>>>>>>> Keys: > > >>>>>>>>>>>> https://dist.apache.org/repos/dist/release/tomee/KEYS > > >>>>>>>>>>>> > > >>>>>>>>>>>> Please vote: > > >>>>>>>>>>>> +1: Release > > >>>>>>>>>>>> -1 Do not release because ... > > >>>>>>>>>>>> > > >>>>>>>>>>>> The vote will be open for 3 days or the consensus is > > >> binding > > >>>> (At > > >>>>>>> least > > >>>>>>>>>> 3 > > >>>>>>>>>>>> binding votes). > > >>>>>>>>>>>> > > >>>>>>>>>>>> Many thanks > > >>>>>>>>>>>> > > >>>>>>>>>>>> Jon > > >>>>>>>>>>> > > >>>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>> > > >>>>>>> > > >>>>>>> > > >>>>>> > > >>>> > > >> > > > >
