Hi Romain,

Tx bud. PR updated. I will merge it later today.
Regarding the side note: I like where it is currently.It makes it simpler
to contribute.

[]s,
Thiago.


On Thu, Sep 20, 2018 at 12:58 AM Romain Manni-Bucau <[email protected]>
wrote:

> Hi Thiago
>
> The block was fine to handle jwt errors and convert them in 4xx but it was
> missing a final "else" to rethrow the original exception.
>
> Side note: since other mp spec are Geronimo ones, maybe this one should be
> migrated too to G impl?
>
> Le jeu. 20 sept. 2018 00:22, Thiago Veronezi <[email protected]> a
> écrit :
>
> > Guys (probably Jean-Louis or Roberto),
> >
> > Can you guys check this PR? https://github.com/apache/tomee/pull/169/
> >
> > I'm trying to use JWT in this project, and got bitten by this catch block
> > hiding a problem with my code. Is this the right way? Maybe I didn't
> quite
> > get what the original comment tries to explain.
> >
> > []s,
> > Thiago.
> >
>

Reply via email to