Another thing I forgot to say. During this process of creating the example you might find a bug, I did it creating the @Gauge example. The MP release is still not final, so it might happen.
If you find it, it will be a great way to start fixing a bug. On Thu, Nov 22, 2018 at 9:42 AM Ivan Junckes Filho <ivanjunc...@gmail.com> wrote: > Hi Ferdi, I am glad you made it here! > > I know you would like to fix a bug in TomEE, but I would like to suggest > that you start with an example. > > It will help you navigate the code and learn more about it before going > into deeper areas. > > I created a JIRA ticket for you, it has a lot of information on how you > can do your first contribution. > https://issues.apache.org/jira/browse/TOMEE-2284 > > We use github, I also added the links in the ticket. It is just the > standard pull request approach. I suggest that you do this: > > 1 - Submit a PR > 2 - Send an email to the list asking someone to review it > 3 - If approved it will be merged by a commiter > > Intellij, maven 3.5 and git are OK. You just need to change to JDK 1.8, we > are working on newer versions but this is still the stable one. > > Does this task work for you? > > If you have questions let us know, there are no silly questions, really! > > > > > On Thu, Nov 22, 2018 at 8:38 AM Ferdi <d...@ferdi.id> wrote: > >> Hi Jean-Louis, >> >> Could you point me to the 'examples' approach you've mentioned? >> >> Generally I'd like to fix things up, but I'm also interested in knowing >> how actually the specifications (from JSR documents and/or MicroProfile >> specs) are implemented. I mean, I know how to build Java apps, classes, >> interfaces and whatnot, so, probably a pointer on how TomEE is >> implemented would be great. Maybe someday I could also contribute to >> Jakarta EE/MicroProfile specs as well. :) >> >> If you feel that what I want is way too great for my current level of >> knowledge, I'm happy, too, with starting small bug fix. >> >> Also probably this. I don't see (or fail miserably during search) guide >> about how to set up development environment and how to deliver patch >> (are we using that or just PR in GitHub?), and mechanism to review the >> work. So if there are references about this so I could learn myself, >> that would be great as well. >> >> For tool reference, I have in my computer now all three IDEs, JDK10 >> (from Oracle if I'm not mistaken), Maven 3.5, IntelliJ Ultimate (this >> years release, I think), and git for Windows. I have a laptop, with >> Fedora instead, git from repo, JDK10 too from Oracle, and IntelliJ >> Ultimate. If there is requirement to switch to another tools (probably >> for cohesion reason), I'd be happy to. >> >> Thank you. >> >> On 11/22/2018 5:49 PM, Jean-Louis Monteiro wrote: >> > Hi Ferdi, >> > >> > Welcome and thank you for the message. >> > >> > It's always great to see new people around. >> > What would you like to work on? >> > >> > From what I can see, I would probably suggest the examples approach. >> This >> > is usually a perfect way to get into TomEE, learn how it works. >> > Eventually, you get into some bugs or improvements you can contribute in >> > addition to the examples. >> > >> > Also if you are learning still, that is a perfect way to learn more and >> > improve your skills. >> > Otherwise, you can look after the JIRA project and see if you see some >> > tickets you would like to work on. >> > >> > Definitely let us know what you would like to do and we'll drive you >> > through the way to do it. >> > >> > Jean-Louis >> >>
