So... Jon suggested to me that the configurable resource can be done in an additional PR by one of the new guys. I think it's an excellent ideal.

If no one disagrees, I'll create a Jira with the details for it.

Bruno Baptista
https://twitter.com/brunobat_


On 23/11/18 14:05, Roberto Cortez wrote:
If we are happy, I would like to merge it. I could use some of the common 
project setup for other work.

On 23 Nov 2018, at 14:01, Bruno Baptista <bruno...@gmail.com> wrote:

Hi Romain,

In the end I decided to simply use the server default, for now.

It will only be used if annotations are called in the code. It's lazily loaded, 
so no worries on that regard.

Cheers.

Bruno Baptista
https://twitter.com/brunobat_


On 23/11/18 12:31, Romain Manni-Bucau wrote:
Didnt you want to make the pool configurable and not instantiated if not
used?

Le ven. 23 nov. 2018 13:20, Daniel Cunha <daniels...@apache.org> a écrit :

Hey Bruno,

awesome! It really sounds good! I just push my +1 :)

Em sex, 23 de nov de 2018 às 06:44, Bruno Baptista <bruno...@gmail.com>
escreveu:

Thanks!

Additionally, I've requested a Safeguard 1.0.1 release. we shouldn't be
using snapshots.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 22/11/18 19:30, Roberto Cortez wrote:
Cool! Thank you.

I’ll have a look.

On 22 Nov 2018, at 19:08, Bruno Baptista <bruno...@gmail.com> wrote:

Hi!

I think the code is ready. Can some of you please review this pull
request:
https://github.com/apache/tomee/pull/201

Related to:TOMEE-2278 <
https://issues.apache.org/jira/browse/TOMEE-2278>-
Use Managed Executor with Safeguard Fault Tolerance lib
Cheers.

--
Bruno Baptista
https://twitter.com/brunobat_


--
Daniel "soro" Cunha
https://twitter.com/dvlc_

Reply via email to