Bruno, see my comment about the maven version here. <goog_727623417> https://github.com/apache/tomee/pull/223#issuecomment-443299902
On Fri, Nov 30, 2018 at 3:29 PM Bruno Baptista <[email protected]> wrote: > Thanks for your feedback César. > > I've replied in the PR. > > Cheers > > Bruno Baptista > https://twitter.com/brunobat_ > > > On 30/11/18 16:41, César Hernández Mendoza wrote: > > Nice job Bruno! > > > > I made some comments on the PR and I like the content the example has so > > far. > > Adding another two classes or +3 test method, then that would be too > much. > > > > > > El vie., 30 nov. 2018 a las 10:09, Bruno Baptista (<[email protected]>) > > escribió: > > > >> Hi Folks, > >> > >> Here is the jira: > >> > >> https://issues.apache.org/jira/browse/TOMEE-2301 > >> > >> I've started a PR... This is not complete. Preview: > >> https://github.com/apache/tomee/pull/223 > >> > >> My plan is to have 3 service classes and 3 test classes to demonstrate: > >> > >> * ManagedExecutorService > >> * ManagedScheduledExecutorService > >> * ManagedThreadFactory > >> > >> Is this too much for one example project? > >> > >> Cheers. > >> > >> -- > >> Bruno Baptista > >> https://twitter.com/brunobat_ > >> > >> > >> >
