A bunch of new faces hoping to contribute just watched you walk up to the project and get code in. You contributed to their excitement immensely!
Not only that but people tend to be afraid of contributing something "simple", feeling it would be unwelcome or in some way "measure" them as not being a good developer, so they grab a hard task and struggle. The reality is we and all open source projects are usually buried under simple tasks not done and that work is incredibly welcome. It's actually *very* excellent you contributed what you did, because it was needed, does help, and there are many other modules that still need the same love. In short, thank you immensely, David! -- David Blevins http://twitter.com/dblevins http://www.tomitribe.com > On Dec 4, 2018, at 3:25 AM, David R. Heffelfinger <dheffelfin...@ensode.com> > wrote: > > Done. > > I know my pull request is a minor thing, sorry I couldn't make a more > significant contribution. > > David > > On Mon, Dec 3, 2018 at 11:59 PM David Blevins <david.blev...@gmail.com> wrote: > Thank you so much for this PR, David! It's merged! :) Congratulations on > your first TomEE commit!! > > Can you add dheffelfinger (a) ensode com to your github account as a > secondary email address? Then you'll get listed here: > > - https://github.com/apache/tomee/graphs/contributors > > As part of all the website work I'd like to add all contributors to the TomEE > site. That tooling would be done via data pulled from Github using this page. > > > -- > David Blevins > http://twitter.com/dblevins > http://www.tomitribe.com > > > On Dec 1, 2018, at 12:32 PM, dheffelfinger <g...@git.apache.org> wrote: > > > > GitHub user dheffelfinger opened a pull request: > > > > https://github.com/apache/tomee/pull/225 > > > > Added diamond operator usage, where appropriate > > > > Since the minimum Java version for the latest version of Tomee is Java > > 8, refactored code to use the diamond operator where appropriate. > > > > Code builds successfully and all Unit Tests still pass. > > > > You can merge this pull request into a Git repository by running: > > > > $ git pull https://github.com/dheffelfinger/tomee master > > > > Alternatively you can review and apply these changes as the patch at: > > > > https://github.com/apache/tomee/pull/225.patch > > > > To close this pull request, make a commit to your master/trunk branch > > with (at least) the following in the commit message: > > > > This closes #225 > > > > ---- > > commit e071b1a2146ce8a506f1ef7bb52d943169543a09 > > Author: David R. Heffelfinger <dheffelfinger@...> > > Date: 2018-12-01T13:49:00Z > > > > Updated project name and description in root pom.xml file. > > > > commit 55b7e2bbbc52fb268e6194114a69fe1ab7378df3 > > Author: David R. Heffelfinger <dheffelfinger@...> > > Date: 2018-12-01T13:53:04Z > > > > Revert "Updated project name and description in root pom.xml file." > > > > This reverts commit e071b1a2146ce8a506f1ef7bb52d943169543a09. > > > > commit bfb1ed40c211e5cf94d53f1230624320e8587349 > > Author: David R. Heffelfinger <dheffelfinger@...> > > Date: 2018-12-01T20:28:24Z > > > > Added diamond operator usage to the OpenEJB Container Core project, > > where appropriate > > > > ---- > > > > > > --- > > > > -- > David R. Heffelfinger, MS > Principal Consultant > Ensode Technology, LLC > http://www.ensode.com > 571-249-3901 > http://www.twitter.com/ensode > http://www.linkedin.com/in/dheffelfinger >
