Hi Daniel,
I'll review it
Bruno Baptista
https://twitter.com/brunobat_
On 05/12/18 14:55, Daniel Cunha wrote:
Hi guys,
Can someone review it: https://github.com/apache/tomee/pull/238?
Thank you! :)
Em ter, 4 de dez de 2018 às 19:45, César Hernández Mendoza <
cesargu...@gmail.com> escreveu:
Got it, thanks for the feedback.
El mar., 4 dic. 2018 a las 13:59, Daniel Cunha (<daniels...@gmail.com>)
escribió:
Hi Cesar,
Thank you. Moving forward discussion here:
Well... I believe which we don't need to have it sync with version used
on
TomEE.
Just the others make sense (javaee-api, openejb, tomee and openjpa). It
will depends of the maven version that user are using. The current
version
that we are using on archetype is good enough for surfire plugin.
Em ter, 4 de dez de 2018 às 15:38, César Hernández Mendoza <
cesargu...@gmail.com> escreveu:
Hi Daniel, awesome,
I already added my comments on the PR.
El mar., 4 dic. 2018 a las 12:14, Daniel Cunha (<daniels...@gmail.com
)
escribió:
Hey,
I just send a PR with the improvements and a little fix:
https://github.com/apache/tomee/pull/238
Let me know what do you think.
Em seg, 3 de dez de 2018 às 20:11, César Hernández Mendoza <
cesargu...@gmail.com> escreveu:
Thank you,
I'm going to update my pr with the improvement you highlighted.
El lun., 3 dic. 2018 a las 16:58, Daniel Cunha (<
daniels...@apache.org
)
escribió:
Hey Cesar,
I pushed a comment on your PR. Hope it helps.
Em seg, 3 de dez de 2018 às 19:54, César Hernández Mendoza <
cesargu...@gmail.com> escreveu:
Hi,
I created a PR for fixing the issue reported on
https://issues.apache.org/jira/browse/TOMEE-2313 about the
failure
on
the
maven project generated by tomee-webapp archetype.
Could someone please review this PR?
--
Atentamente:
César Hernández Mendoza.
--
Daniel "soro" Cunha
https://twitter.com/dvlc_
--
Atentamente:
César Hernández Mendoza.
--
Daniel "soro" Cunha
https://twitter.com/dvlc_
--
Atentamente:
César Hernández Mendoza.
--
Daniel "soro" Cunha
https://twitter.com/dvlc_
--
Atentamente:
César Hernández Mendoza.
