Hey, imho it would be a good improvement to reduce legacy code constructs from below Java 8 in the master branch.
Some PRs are just merged into the master related to the use of diamond operator etc. and other stuff. However, we should come to some general agreement about this imho. And of course open a JIRA to signalize someone is working on it. Just my personal opinion. Best, Richard Am 5. Dezember 2018 16:27:50 MEZ schrieb "Otávio Gonçalves de Santana" <[email protected]>: >Hello everyone, I'm studying the code, mostly the container module. It >seems that in the master we support Java 8. >My question: Does make sense to create PRs to update some APIs to a >modern >way? >I mean, e.g.: > >for (int i = 0; i < rules.length; i++) { > rules[i].validate(appModule); >} > >To > >for (ValidationRule rule : rules) { > rule.validate(appModule); >} > > > >Ps: That does not impact in performance, just does the code >cleaner/readable and more natural to maintainer IMHO.
