Running a build here too. If stuff breaks, we can revert it. Cheers
Jon On Thu, Dec 13, 2018 at 11:36 AM Jean-Louis Monteiro < jlmonte...@tomitribe.com> wrote: > Ah ok, I was running a build first. > So Should I leave it? > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro > http://www.tomitribe.com > > > On Thu, Dec 13, 2018 at 12:10 PM Jonathan Gallimore < > jonathan.gallim...@gmail.com> wrote: > > > Looks like that was a popular one :) > > > > On Thu, Dec 13, 2018 at 11:09 AM Jonathan Gallimore < > > jonathan.gallim...@gmail.com> wrote: > > > > > Awesome, thank you! Merged. > > > > > > Jon > > > > > > On Thu, Dec 13, 2018 at 10:56 AM Otávio Gonçalves de Santana < > > > osant...@tomitribe.com> wrote: > > > > > >> It PR adds the getModuleId method as a fallback when getJarLocation is > > >> null > > >> at CmpJpaConversion, this way it keeps the desired behavior and fixes > > the > > >> when the getJarLocation is null such as the CheckMissingClassTest. > > >> > > >> https://github.com/apache/tomee/pull/274 > > >> > > > > > >
