Well, not sure if I explained myself correctly. The other tests are just with the TCK’s because there are no implementations in TomEE. Well we could have go to the Geronimo projects and add the tests there, but we are also testing parts of the TomEE integration, so they need to live somewhere.
> On 14 Dec 2018, at 10:43, Jean-Louis Monteiro <[email protected]> > wrote: > > As I said, along side with the implementation. But that was a gut feeling. > If others are in TCK, I'd rather vote for consistency so it's easier for > us, new contributors to know where to look at > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro > http://www.tomitribe.com > > > On Fri, Dec 14, 2018 at 11:41 AM Roberto Cortez <[email protected]> > wrote: > >> Well, because we don’t have any other implementations in TomEE other than >> JWT, in a couple of cases we did implement some additional tests, and they >> were done on the TCK modules (for instance Configuration). Where do you >> suggest to add these? >> >>> On 14 Dec 2018, at 10:35, Jean-Louis Monteiro <[email protected]> >> wrote: >>> >>> Hummm >>> That is not what I would be expecting actually. >>> I was expecting the TCK modules to be just wiring to run external TCK >> tests. >>> >>> And actual implementation tests to be along side the implementation. >>> >>> -- >>> Jean-Louis Monteiro >>> http://twitter.com/jlouismonteiro >>> http://www.tomitribe.com >>> >>> >>> On Fri, Dec 14, 2018 at 11:26 AM Roberto Cortez >> <[email protected]> >>> wrote: >>> >>>> Tests can also be added in the TCK module. I think they should be added >>>> there actually, since all the other additional tests for the other MP >>>> implementations are added in their own TCK modules. >>>> >>>>> On 14 Dec 2018, at 06:34, Jean-Louis Monteiro < >> [email protected]> >>>> wrote: >>>>> >>>>> Hey Cesar, >>>>> >>>>> Thanks, I'll review and merge for you if ok. >>>>> You are correct, we currently rely on the TCKs only for MP-JWT. >>>>> >>>>> This is the bare minimum and ideally we should add our own tests in the >>>>> mp-jwt module because the TCKs can't test everything. >>>>> >>>>> >>>>> -- >>>>> Jean-Louis Monteiro >>>>> http://twitter.com/jlouismonteiro >>>>> http://www.tomitribe.com >>>>> >>>>> >>>>> On Fri, Dec 14, 2018 at 4:42 AM César Hernández Mendoza < >>>>> [email protected]> wrote: >>>>> >>>>>> The PR for this ticket is ready for review. >>>>>> >>>>>> PR: https://github.com/apache/tomee/pull/275 >>>>>> Ticket: https://issues.apache.org/jira/browse/TOMEE-2357 >>>>>> >>>>>> The fix for this issue is in the module `/mp-jwt`, I didn't find any >>>> test >>>>>> package on this module. >>>>>> Is this on purpose because we have the module >>>> `/tck/microprofile-tck/jwt` ? >>>>>> >>>>>> Anyway, I included in the PR the test scenario as part of the >>>>>> `examples/mp-rest-jwt` project. >>>>>> >>>>>> >>>>>> >>>>>> El mié., 12 dic. 2018 a las 5:44, Roberto Cortez >>>>>> (<[email protected]>) escribió: >>>>>> >>>>>>> Assigned! >>>>>>> >>>>>>>> On 12 Dec 2018, at 05:33, César Hernández Mendoza < >>>>>> [email protected]> >>>>>>> wrote: >>>>>>>> >>>>>>>> During the creation of a second version of the MP JWT example [1] I >>>>>>> found a >>>>>>>> bug related with the enforcement of the @RolesAllowed validation. >>>>>>>> >>>>>>>> I created https://issues.apache.org/jira/browse/TOMEE-2357 with the >>>>>>>> details. If nobody is currently working on this issue, I would like >> to >>>>>>>> request to JIRA admins to assign the ticket to me so I can work on >> the >>>>>>> fix >>>>>>>> this week. >>>>>>>> >>>>>>>> [1] email thread: "MP JWT example revisited" >>>>>>>> -- >>>>>>>> Atentamente: >>>>>>>> César Hernández Mendoza. >>>>>>> >>>>>>> >>>>>> >>>>>> -- >>>>>> Atentamente: >>>>>> César Hernández Mendoza. >>>>>> >>>> >>>> >> >>
