> @Jon: instead of the logs, could we instead rely on latches? > I was thinking about wrapping up the Tracker (delegate pattern) and use a > latch so the test could actually way and avoid some timing issues.
That sounds like a great approach. That test and associated fix came from some pretty intensive work with Websphere MQ. If the auto connection tracker code changed, it would probably be worthwhile me turning that setup on and running that stress test again. Jon On Fri, Dec 14, 2018 at 4:18 PM Jean-Louis Monteiro < [email protected]> wrote: > Starting a new thread so hopefully it makes it easier to track and follow. > > So looks like on Buildbot AutoConnectionTrackerTest is failing randomly > > [ERROR] Failures: > [ERROR] AutoConnectionTrackerTest.test:198 expected:<1> but was:<0> > > Thanks Roberto for reporting. > I also ran this test many times locally and it works. > > I have looked into the code and I see possible issues > - test is relying on logs so even with async=false, is there a way > something could not be flushed out. > - System.gc() maybe does not fully clean up connections > - Tracker did not get time to write down the log statement > > Maybe others. > > I'm proposing here to attempt adding some log statements to see if we can > have some pointers. > > @Jon: instead of the logs, could we instead rely on latches? > I was thinking about wrapping up the Tracker (delegate pattern) and use a > latch so the test could actually way and avoid some timing issues. > > > > > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro > http://www.tomitribe.com >
