Github user jeanouii commented on the issue:

    https://github.com/apache/tomee/pull/262
  
    I am overall ok with the PR but the javadoc part is more the one to discuss.
    
    I agree with @pzygielo. If JavaDoc does not bring anything more than you 
can read with the code itself, then I just remove it.
    
    JavaDoc listing the attributes and the throws are useless to me because I 
can read it on the code itself. Remember that the best documentation is the 
code. So if the code is not meaningful, the javadoc won't make it clear. So I'm 
tempted to address the root cause first and fix the code.
    
    Than being said, @cicekhayri can you look at @pzygielo comments and take 
them into account so I can merge this PR before it grows and conflicts start 
appearing?


---

Reply via email to