Github user gerdogdu commented on a diff in the pull request:
https://github.com/apache/tomee/pull/332#discussion_r244585692
--- Diff:
container/openejb-core/src/main/java/org/apache/openejb/OpenEjbContainer.java
---
@@ -71,57 +50,74 @@
import java.net.MalformedURLException;
import java.net.URL;
import java.net.URLClassLoader;
-import java.util.Arrays;
-import java.util.Collections;
-import java.util.HashMap;
-import java.util.Iterator;
-import java.util.LinkedHashSet;
-import java.util.List;
-import java.util.Map;
-import java.util.Properties;
-import java.util.Set;
+import java.util.*;
import java.util.logging.LogManager;
import static org.apache.openejb.cdi.ScopeHelper.startContexts;
import static org.apache.openejb.cdi.ScopeHelper.stopContexts;
/**
- * @version $Rev$ $Date$
+ * Embeddable {@link EJBContainer} implementation based
+ * on OpenEJB container.
*/
public final class OpenEjbContainer extends EJBContainer {
+
static {
// if tomee embedded was ran we'll lost log otherwise
- final String logManger =
JavaSecurityManagers.getSystemProperty("java.util.logging.manager");
- if (logManger != null) {
+ final String logManager =
JavaSecurityManagers.getSystemProperty("java.util.logging.manager");
+ if (logManager != null) {
try {
-
Thread.currentThread().getContextClassLoader().loadClass(logManger);
+
Thread.currentThread().getContextClassLoader().loadClass(logManager);
} catch (final Exception ignored) {
- final Field field;
+ Field field = null;
+ boolean accessible = false;
try {
field = LogManager.class.getDeclaredField("manager");
- field.setAccessible(true);
- field.set(null, new
JuliLogStreamFactory.OpenEJBLogManager());
+ if(field != null){
+ accessible = field.isAccessible();
+ field.setAccessible(true);
+ field.set(null, new
JuliLogStreamFactory.OpenEJBLogManager());
+ }
+
} catch (final Exception ignore) {
// ignore
+ }finally{
+ if(field != null){
+ field.setAccessible(accessible);
--- End diff --
> ok Gurkan.
So, ok means will you commit?
---
