> On Jan 6, 2019, at 1:23 PM, Gurkan Erdogdu <[email protected]> wrote: > > Thank you David. > One question, do we need to comment on the interface or concrete class? For > example, Assembler interface in org.apache.openejb.spi package? I think > commenting on the interface is better and then for extra comments in > concrete class.
I think that's a good approach; interface where possible, concrete class where there are implementation specific details. The goals are definitely interface worthy. All the information about AnnotationDeployer and AppModule is specific to the concrete class, also known as the ClassicAssembler. Here's some old docs on it. - http://tomee.apache.org/dev/design-assembler.html Likely we should move that info into the classes themselves, then delete those pages so we don't have repetitive (and therefore hard to maintain) sources of truth. -David
