Thank you for the feedback,
site navigation has links to /latest/examples/ and similar -- people were
> issuing PRs for broken links in headers, footers, menues, all dec and
> they're finally (hopefully) settled.
That's a good point, I was not aware of this /latest/examples/ reference
inside the docs and website. I only updated the doc.html page.
We don't have direct access to the second svn, so I don't know of any way
> to avoid doubling the size of that second repo.
I don't follow you entirely on this one. So far my understanding is that
the process for building the site is divided into three major steps:
1) Download all the branches into: tomee-site-generator/repos
2) Copy from /repos folder all the branches
into: tomee-site-generator/target/jbake/content
3) Bake the tomee-site-generator/target/jbake/content folder structure to
generate the final website in: tomee-site-generator/target/site-1.0-SNAPSHOT
My PR only touches step 2) without duplicating the content of the
documentation in English. I added /en to standardize in the code the
indexing process that also is performed on step 2) to generate the
index.htmll per documentation Category, and Language on each Branch:
--tomee-site-generator/target/jbake/content/tomee-8.0
----- en
|--examples
----- es
|--examples
----- index.adoc
Tomorrow I'm going to analyze how to remove /en from the website structure.
El lun., 14 ene. 2019 a las 17:45, David Blevins (<david.blev...@gmail.com>)
escribió:
> Little feedback on my side of the fence. Can we avoid adding "en" to the
> path of the default language?
>
> Couple small reasons:
>
> - site navigation has links to /latest/examples/ and similar -- people
> were issuing PRs for broken links in headers, footers, menues, all dec and
> they're finally (hopefully) settled.
>
> - everything is in svn, the tomee-8.0 dir alone is 133M, and the site
> overall is 1.7G. The initial push took a few hours to sync and moving
> everything into an 'en/' directory will double the size. The process
> actually involves one svn synching to another svn. We don't have direct
> access to the second svn, so I don't know of any way to avoid doubling the
> size of that second repo.
>
>
> --
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
>
> > On Jan 14, 2019, at 12:57 PM, César Hernández Mendoza <
> cesargu...@gmail.com> wrote:
> >
> > Thanks Bruno.
> > I'm working on fixing that test and will be back with an updated PR when
> > ready.
> >
> > El lun., 14 ene. 2019 a las 5:33, Bruno Baptista (<bruno...@gmail.com>)
> > escribió:
> >
> >> Hi César,
> >>
> >> I've reviewed the PR and found an error:
> >>
> >>
> >> Tests in error:
> >> testProcess(org.apache.tomee.website.GroupedIndexTest):
> >> java.io.FileNotFoundException:
> >> /tmp/temp5520959884794493991dir/en/examples/index.html (No such file or
> >> directory)
> >>
> >> Tests run: 9, Failures: 0, Errors: 1, Skipped: 0
> >>
> >> [INFO]
> >> ------------------------------------------------------------------------
> >> [INFO] BUILD FAILURE
> >> [INFO]
> >> ------------------------------------------------------------------------
> >>
> >> Left a comment in the PR.
> >>
> >> Cheers
> >>
> >> Bruno Baptista
> >> https://twitter.com/brunobat_
> >>
> >>
> >> On 11/01/19 22:23, César Hernández Mendoza wrote:
> >>> Hi all,
> >>> In case somebody is wondering how to review this PR
> >>> https://github.com/apache/tomee-site-generator/pull/16,
> >>> once you have the PR on your local git:
> >>>
> >>> 1. build the project: `tomee-site-generator$ mvn clean install`
> >>> 3. Build and run the project: `tomee-site-generator$ mvn clean compile
> >>> -Djbake.http=true`
> >>> 4. The project should show in `http://localhost:8080/docs.html`
> <http://localhost:8080/docs.html>
> >> <http://localhost:8080/docs.html>
> >>> <http://localhost:8080/docs.html> the [es] link to the examples in
> >> Spanish.
> >>> So far tomee master only has 1 readme translated into spanish but you
> can
> >>> add more README_es.adoc files to any of your
> >>> `tomee-site-generator/repos/tomee-8.0/examples`.
> >>>
> >>> I'm more than happy to resolve any questions that may arise for the
> >> review
> >>> of this PR.
> >>>
> >>>
> >>>
> >>> El mié., 9 ene. 2019 a las 20:44, César Hernández Mendoza (<
> >>> cesargu...@gmail.com>) escribió:
> >>>
> >>>> Hi, The new PR with the requested changes is ready for review.
> >>>>
> >>>> Now the internationalization for examples follows the format like:
> >>>> example: http://localhost:8080/tomee-8.0/es/examples/
> >>>>
> >>>> I added a vide on the ticket:
> >>>>
> >>
> https://issues.apache.org/jira/browse/TOMEE-2444?focusedCommentId=16738926&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16738926
> >>>>
> >>>> El mié., 9 ene. 2019 a las 12:39, David Blevins (<
> >> david.blev...@gmail.com>)
> >>>> escribió:
> >>>>
> >>>>>> On Jan 8, 2019, at 6:49 PM, César Hernández Mendoza <
> >>>>> cesargu...@gmail.com> wrote:
> >>>>>> I have to be honest, I had to untie a couple of lambdas into loops
> >>>>>> while I was studying and learning the code.
> >>>>>> I need to improve my functional skills to refactor that code but in
> >> the
> >>>>>> meantime, I'm moving forward and will tackle the code cleanup and
> >>>>> sharpness
> >>>>>> once we all agree on the functionality itself.
> >>>>> That's absolutely fine. Work at whatever language level you're
> >>>>> comfortable with.
> >>>>>
> >>>>> I think as a project we should be very ok with people simplifying
> code
> >> so
> >>>>> they can understand it -- even if that means removing fancy new
> syntax.
> >>>>>
> >>>>>
> >>>>> -David
> >>>>>
> >>>>>
> >>>>>
> >>>> --
> >>>> Atentamente:
> >>>> César Hernández Mendoza.
> >>>>
> >>>
> >>
> >
> >
> > --
> > Atentamente:
> > César Hernández Mendoza.
>
>
--
Atentamente:
César Hernández Mendoza.
