> On Feb 27, 2019, at 5:14 PM, David Blevins <david.blev...@gmail.com> wrote: > > I added you to the contributors group and assigned that JIRA to you. > > It's a broad sounding ticket, so I recommend picking a small spot of the code > and focusing on that in the first PR so people can get a taste of what you > have in mind and give feedback.
You were fast :) I like the change. Special thank you for making that MVN_JNDI_PREFIX string a variable rather than a constant. You and I clearly have the same thoughts on the subject. Most people go for the static constant, but this just slows down class initialization which in turn slows startup time. Then it slaps you again by adding to the memory you need. There are people who write blog posts judging servers by how fast they start and how much memory they take at startup... and they most go and fill it with an app that has tons of needless static constants. Don't get me started. :) Thank you for the contribution. Congratulations on the first commit! Welcome aboard! If you want to do a ton more PRs like that, go for it! -David
