AndyGee commented on a change in pull request #360: Cleanup test code and also
minor changes in the tested class.
URL: https://github.com/apache/tomee/pull/360#discussion_r268966390
##########
File path:
container/openejb-core/src/main/java/org/apache/openejb/resource/AutoConnectionTracker.java
##########
@@ -58,16 +60,18 @@
private final TransactionManager txMgr;
private final Logger logger =
Logger.getInstance(LogCategory.OPENEJB_CONNECTOR,
"org.apache.openejb.resource");
private final ConcurrentMap<ManagedConnectionInfo, ProxyPhantomReference>
references = new ConcurrentHashMap<>();
- private final ReferenceQueue referenceQueue = new ReferenceQueue();
+ private final ReferenceQueue<ConnectionInvocationHandler> referenceQueue =
new ReferenceQueue<>();
private final ConcurrentMap<Class<?>, Class<?>> proxies = new
ConcurrentHashMap<>();
private final ConcurrentMap<Class<?>, Class<?>[]> interfaces = new
ConcurrentHashMap<>();
private final boolean cleanupLeakedConnections;
+ private final ExecutorService executorService;
Review comment:
When using a service, the service should be shut down. I'm not sure right
now where the best place for that is, but I'd still like to see the call
somewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
