doychin commented on a change in pull request #451: Remove unused method
(tomee-2499)
URL: https://github.com/apache/tomee/pull/451#discussion_r270573483
##########
File path:
container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
##########
@@ -2259,22 +2259,6 @@ public void destroyApplication(final String filePath)
throws UndeployException,
}
}
- public void destroyApplication(final AppContext appContext) throws
UndeployException {
Review comment:
This method will never work. It will always fail with IllegalStateException.
Deployed applications are kept in a map and the key is the path of the deployed
application. Path information is not available in AppContext and in this method
application is searched by appContext.getId() which is not app path.
That is the main reason I suggest this method to be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
