cesarhernandezgt commented on a change in pull request #448: Tomee 2482
synchronize examples
URL: https://github.com/apache/tomee/pull/448#discussion_r275959293
##########
File path: examples/pom.xml
##########
@@ -38,13 +38,15 @@
<module>access-timeout-meta</module>
<module>access-timeout</module>
<module>alternate-descriptors</module>
+ <module>applet</module>
Review comment:
Yes, thanks for the pointer @ShermanMarshall
My observation arises from the fact that, as far as I know, the
[buildbot](https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8)
infrastructure is unaware of pre-configurations like keystores or keys.
Among other steps, buildbot first integrate skipping the test and then
triggering all the tests (including the ones from the examples). With this PR
both commands will fail with the error showed above.
```
mvn -e --show-version --fail-at-end
-Djava.io.tmpdir=/tmp/tomee-trunk-ubuntu-jvm8 clean install
-DfailIfNoTests=false -DskipTests
mvn --show-version --fail-at-end
-Djava.io.tmpdir=/tmp/tomee-trunk-ubuntu-jvm8 clean install -Pall-adapters
-Dsurefire.useFile=false -DdisableXmlReport=true
-Dopenejb.arquillian.debug=true -DTOMEE_LOCK_FILE=/tmp/tomee.port.lock
```
I'm going to ask for feedback on the mailing list to double check with
committers if my analysis is correct or not :).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
