jeanouii commented on a change in pull request #465: [WIP] TOMEE-2515
MicroProfile JWT 1.1 Cleanup
URL: https://github.com/apache/tomee/pull/465#discussion_r281501700
##########
File path:
mp-jwt/src/main/java/org/apache/tomee/microprofile/jwt/config/JWTAuthConfiguration.java
##########
@@ -29,47 +29,47 @@
/**
* The public key and expected issuer needed to validate a token.
*/
-public class JWTAuthContextInfo {
- private static final Logger logger =
Logger.getLogger(JWTAuthContextInfo.class.getName());
+public class JWTAuthConfiguration {
+ private static final Logger logger =
Logger.getLogger(JWTAuthConfiguration.class.getName());
public static final String DEFAULT_KEY = "DEFAULT";
- private Map<String, Key> signerKeys;
- private String issuedBy;
+ private Map<String, Key> publicKeys;
Review comment:
Not so sure about this one.
Key is the base class and can be a public key or a secret key.
What about signingKey?
It would be valid for either symmetric or asymmetric key.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
