Yes, that flag was added there on purpose to enable OpenAPI to reach the real Application and not the wrapper classed created by TomEE.
That seemed to be enough to pass the TCK. Now if there are other cases that are not working, we need to figure out why exactly. Cheers, Roberto > On 14 May 2019, at 17:35, Jonathan Gallimore <[email protected]> > wrote: > > I think the PR should include the removal of that flag. I'm guessing that > this is something to do with it: > https://github.com/apache/tomee/blob/master/tomee/tomee-microprofile/mp-common/src/main/java/org/apache/tomee/microprofile/TomEEMicroProfileListener.java#L93 > . > > That's in production code though. If we're passing the TCK, but something > isn't working in real-life, then we need to understand why, and if there's > a gap in the TCK tests. > > Jon > > On Tue, May 14, 2019 at 4:58 PM Ivan Junckes Filho <[email protected]> > wrote: > >> That is the goal of the PR. >> >> On Tue, May 14, 2019 at 12:40 PM Jonathan Gallimore < >> [email protected]> wrote: >> >>>> Removing that flag doesn't fix the problem unfortunately. >>> >>> With this PR, the TCK (which is running with a flag) should now pass >>> without the flag, is that correct? >>> >>> On Tue, May 14, 2019 at 3:38 PM Ivan Junckes Filho < >> [email protected]> >>> wrote: >>> >>>> Removing that flag doesn't fix the problem unfortunately. I saw your >>>> comment Jon, but the issue is not with Geronimo as far as I understand. >>>> TomEE uses InternalApplication instead of using the custom Application >>>> config and because of that geronimo doesn't pick it up in the geronimo >>>> extension. >>>> >>>> I added the apache header Jean-Louis. I think Otavio asked for help to >>>> write a test, but nobody replied. >>>> >>>> Basically openapiextension ignores @OpenAPIDefinition and the result is >>>> that none of those values are added to the final openapi document. >>>> >>>> On Tue, May 14, 2019 at 10:26 AM Jean-Louis Monteiro < >>>> [email protected]> wrote: >>>> >>>>> Agreed. >>>>> >>>>> Le mar. 14 mai 2019 à 15:24, Jonathan Gallimore < >>>>> [email protected]> a écrit : >>>>> >>>>>> I added a note on the PR. I did find the discussion on the mailing >>>> list: >>>>>> >>>>>> >>>>> >>>> >>> >> http://tomee-openejb.979440.n4.nabble.com/OpenAPIDefinition-not-working-td4687918.html >>>>>> . >>>>>> >>>>>> It sounded like a flag is needed to pass the TCK currently - >>> preference >>>>>> would be that there is a test for this issue (which could just be >> an >>>>>> Arquillian test which reads from /openapi, right?), but at the very >>>>> least, >>>>>> some indication that this is covered by the TCK and the removal of >>>>>> the openejb.cxf-rs.cache-application=false setting in the existing >>> TCK >>>>>> module. >>>>>> >>>>>> Jon >>>>>> >>>>>> >>>>>> On Tue, May 14, 2019 at 1:29 PM Ivan Junckes Filho < >>>>> [email protected]> >>>>>> wrote: >>>>>> >>>>>>> Hey guys, this PR from Otavio fixes a very bad issue with OpenAPI >>> in >>>>>> TomEE >>>>>>> regarding the use of InternalApplication. >>>>>>> >>>>>>> https://issues.apache.org/jira/browse/TOMEE-2502 >>>>>>> >>>>>>> I reviewed the PR and it really fixes the issue. >>>>>>> >>>>>>> Can someone please merge this? This is pending for awhile and I >>> would >>>>>>> appreciate a lot to have this fix in. >>>>>>> >>>>>>> https://github.com/apache/tomee/pull/454 >>>>>>> >>>>>> >>>>> >>>> >>> >>
