If applet is included in the build (per the current PR) - do you know if the build passes?
Jon On Wed, Apr 17, 2019 at 8:08 PM Jonathan Gallimore < [email protected]> wrote: > Good question. The examples are designed to run standalone in their own > right, so it isn't a hard requirement to include them in the build, > although it is nice to do so if possible. Buildbot will be unaware of any > pre-config that needs to be done. In theory, we might be able to make > buildbot do the pre-config bit, and then persuade everyone building TomEE > to do the same. A better approach would be to make the applet sample do > whatever is necessary from its pom.xml. The webservice-ws-security example > builds some keystores before execution using the Maven antrun plugin: > https://github.com/apache/tomee/blob/master/examples/webservice-ws-security/pom.xml#L109-L126 > - > could something similar be done for applet? > > Jon > > On Wed, Apr 17, 2019 at 4:54 AM César Hernández Mendoza < > [email protected]> wrote: > >> We are analyzing with Sherman TomEE-2482 that brings back to >> examples/pom.xml some missing modules. >> >> Can some of the committer remember if this issue [1] is the motivation why >> the applet module is not currently part of examples/pom.xml modules? >> As as far as I know, the buildbot infrastructure is unaware of >> pre-configurations like keystores or keys. >> >> [1] https://github.com/apache/tomee/pull/448#discussion_r275924881 >> >> El mar., 16 abr. 2019 a las 12:20, César Hernández Mendoza (< >> [email protected]>) escribió: >> >> > Hi Sherman, >> > >> > Thank you for providing visibility on the mailing list. >> > About https://issues.apache.org/jira/browse/TOMEE-2482, I left a review >> > on: https://github.com/apache/tomee/pull/448 >> > About https://issues.apache.org/jira/browse/TOMEE-2485, It seems to me >> > that this ticket PR #460 contains also the changes from TOMEE-2482 >> (PR#448) >> > so I got the same issue reported on #448. >> > >> > >> > >> > El lun., 15 abr. 2019 a las 21:20, Sherman Marshall (< >> > [email protected]>) escribió: >> > >> >> https://issues.apache.org/jira/browse/TOMEE-2482 >> >> <https://issues.apache.org/jira/browse/TOMEE-2485> >> >> >> >> Hey everyone, >> >> >> >> Thanks for the effort! I'm still learning my way around the project, >> and >> >> have been advised to reach out to the community when a new PR is ready. >> >> >> >> I picked up a task to make the examples a bit cleaner (+ adding where I >> >> can), and it is up for review. I discussed some confusion over the >> >> bval-example with @danielsoro, but ultimately was able to get to the >> >> bottom >> >> of the issue, and think it is resolved. >> >> >> >> If anyone could take the time to glance at the PR, offer comment, >> >> criticism, or give it the thumbs up, I would appreciate it! >> >> >> >> Regards, >> >> >> >> Sherman >> >> >> > >> > >> > -- >> > Atentamente: >> > César Hernández. >> > >> >> >> -- >> Atentamente: >> César Hernández. >> >
