Cesar I backported this to 1.7.x: https://github.com/apache/tomee/pull/489 I think this and https://github.com/apache/tomee/pull/488 should be ready for merge now.
Can you review? If you're happy, I'll merge. We should start collecting some configs for different databases: Oracle SQL Server Postgres MySQL and compare timings both with and without openejb.datasource.pool enabled with both master and 1.7.x. If we see some "quality" issues along the way, I think we should call them out. So, currently, with TomEE 8 (master) I have found that you *have* to specify a JdbcUrl for the XA datasource otherwise TomEE follows the wrong path and you end up with a HSQLDB connection. I also get warnings like this: 18-Jun-2019 14:41:41.583 WARNING [main] org.apache.openejb.assembler.classic.Assembler.unusedProperty unused property 'JdbcUrl' for resource 'dbtest/movieDatabase' 18-Jun-2019 14:41:41.583 WARNING [main] org.apache.openejb.assembler.classic.Assembler.unusedProperty unused property 'UserName' for resource 'dbtest/movieDatabase' 18-Jun-2019 14:41:41.584 WARNING [main] org.apache.openejb.assembler.classic.Assembler.unusedProperty unused property 'Password' for resource 'dbtest/movieDatabase' 18-Jun-2019 14:41:41.584 WARNING [main] org.apache.openejb.assembler.classic.Assembler.unusedProperty unused property 'PasswordCipher' for resource 'dbtest/movieDatabase' 18-Jun-2019 14:41:41.584 WARNING [main] org.apache.openejb.assembler.classic.Assembler.unusedProperty unused property 'ValidationQuery' for resource 'dbtest/movieDatabase' 18-Jun-2019 14:41:41.585 WARNING [main] org.apache.openejb.assembler.classic.Assembler.unusedProperty unused property 'InitialSize' for resource 'dbtest/movieDatabase' 18-Jun-2019 14:41:41.585 WARNING [main] org.apache.openejb.assembler.classic.Assembler.unusedProperty unused property 'MaxActive' for resource 'dbtest/movieDatabase' 18-Jun-2019 14:41:41.585 WARNING [main] org.apache.openejb.assembler.classic.Assembler.unusedProperty unused property 'MaxIdle' for resource 'dbtest/movieDatabase' 18-Jun-2019 14:41:41.585 WARNING [main] org.apache.openejb.assembler.classic.Assembler.unusedProperty unused property 'MinIdle' for resource 'dbtest/movieDatabase' 18-Jun-2019 14:41:41.585 WARNING [main] org.apache.openejb.assembler.classic.Assembler.unusedProperty unused property 'TestWhileIdle' for resource 'dbtest/movieDatabase' 18-Jun-2019 14:41:41.586 WARNING [main] org.apache.openejb.assembler.classic.Assembler.unusedProperty unused property 'TestOnBorrow' for resource 'dbtest/movieDatabase' 18-Jun-2019 14:41:41.586 WARNING [main] org.apache.openejb.assembler.classic.Assembler.unusedProperty unused property 'TestOnReturn' for resource 'dbtest/movieDatabase' 18-Jun-2019 14:41:41.586 WARNING [main] org.apache.openejb.assembler.classic.Assembler.unusedProperty unused property 'AccessToUnderlyingConnectionAllowed' for resource 'dbtest/movieDatabase' 18-Jun-2019 14:41:41.586 WARNING [main] org.apache.openejb.assembler.classic.Assembler.unusedProperty unused property 'PoolPreparedStatements' for resource 'dbtest/movieDatabase' 18-Jun-2019 14:41:41.586 WARNING [main] org.apache.openejb.assembler.classic.Assembler.unusedProperty unused property 'MaxOpenPreparedStatements' for resource 'dbtest/movieDatabase' which may be accurate, but I'd like to pin down where they are coming from and try and provide something more helpful. Finally, configuring XA datasources generally feels a bit painful. It would be nice have a tool that can help build the config for you. Jon On Tue, Jun 18, 2019 at 11:14 AM Jonathan Gallimore < [email protected]> wrote: > Hi Cesar > > I had a go with your XA sample PR. I've picked it up and expanded on it: > https://github.com/apache/tomee/pull/488 > > Can you take a look and see what you think? I've removed any references to > ojdbc jar, and tweaked so the jars for the Grinder framework aren't > committed to the repository. Out of the box, it runs with Derby, but I > think providing instructions for Oracle, SQL Server, etc would be > worthwhile so people can run their own tests against different databases. > > Thanks > > Jon >
