cbos edited a comment on issue #506: TOMEE-2564 Classpath with :: on Linux is 
cause an infinite loop on War deploy
URL: https://github.com/apache/tomee/pull/506#issuecomment-509605643
 
 
   > Good catch. Is there a way we could test the change without introducing an 
infinite loop? I'm also wondering if we could/should check the file exists, and 
perhaps add log some warnings. What do you think?
   
   An exists() check on the file before converting the file to URL could have 
solved the issue as well. It returns false. 
   What is the preference is this case?
   
   Writing a test might be possible. At this moment there is in the class 
TomEEJarScannerTest only a test for the TomEEFilter, I did not try to have a 
test for TomEEJarScanner.
   It requires tweaking of the java.class.path System property in the test (Add 
:: via setProperty and revert to the old value in the @after).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to