Hi guys, I think I have done good progress. Most of the build is passing with Java 11. With Java 8, there should not be any backward compatibility issues as I tested locally.
I don't want to stack the PR so it becomes a huge PR and we are afraid to merge it. Any issue if I merge the current one and get a new snapshot deployed? If something is broken with Java 8, I can either revert or fix very quick afterwards. Thoughts? PR is https://github.com/apache/tomee/pull/523 I also would like to run Jakarta EE 8 TCK with both Java 8 and Java 11 so we get a view of were we are. I have a couple of tickets and tasks that I gonna file into JIRA today -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Tue, Jul 23, 2019 at 4:30 PM Jean-Louis Monteiro < [email protected]> wrote: > I ended up throwing all the PR away and starting from scratch again. > There were too many changes and I did not know anymore what they were for. > > Went with a different approach to see if it works better. > On master, we introduced some garbage by the way, not sure why but we'll > have to fix some pom stuff because I suspect we have too much stuff in the > binaries. > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro > http://www.tomitribe.com > > > On Tue, Jul 23, 2019 at 3:28 PM Jean-Louis Monteiro < > [email protected]> wrote: > >> Hey David, >> >> Thanks for the feedback. >> I already removed some of them. It has some side effects that I still >> need to investigate. For instance, removing soap-api, makes the >> UniverseTest to fail. The Geronimo service locator seems to mess up the >> test. >> >> >> >> -- >> Jean-Louis Monteiro >> http://twitter.com/jlouismonteiro >> http://www.tomitribe.com >> >> >> On Tue, Jul 23, 2019 at 3:11 PM David Blevins <[email protected]> >> wrote: >> >>> > On Jul 23, 2019, at 5:46 AM, Jonathan Gallimore < >>> [email protected]> wrote: >>> > >>> > I did a build on master and on the branch. The "plus" artifact for the >>> > branch has the following library diffs compared with master: >>> >>> Thanks! >>> >>> > +jacorb-3.9 >>> > +jacorb-omgapi-3.9 >>> > +jboss-rmi-api_1.0_spec-1.0.6.Final >>> >>> These should be cut out as we do not actually implement the CORBA/IIOP >>> and CSIv2 code required by the full profile. >>> >>> > +jakartax.activation-api-1.2.1 >>> > +javax.activation-1.2.0 >>> > +javax.activation-api-1.2.0 >>> > +javax.xml.soap-api-1.4.0 >>> > +management-api-3.0.0-b012 >>> >>> The Geronimo versions of these should already be in our javaee-api jar. >>> >>> >>> -David >>> >>>
