I've spent some time reviewing: * Build looks ok * Libraries added and licenses look ok * Upgraded a production application to this RC running on Java 11 - looks good * Getting a RAT report has proved to be a pain. Running RAT standalone produces this report: https://gist.github.com/jgallimore/be3e120b76c5424ed4903fe06ff6337a
Looks like we have 43 java files and 62 XML files without headers. I'll correct these and re-roll. If there's any other feedback, please let me know here and I'll incorporate that into a re-roll tonight. Thanks Jon On Thu, Sep 12, 2019 at 3:09 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Hi > > To assist with the review - here are the library changes from 8.0.0-M3: > > > https://dist.apache.org/repos/dist/dev/tomee/staging-1145/tomee-8.0.0/DIFF.txt > > To save you clicking, here's the content: > > apache-tomee 8.0.0 webprofile > > ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko] > ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko] > ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko] > ADD jackson-annotations-2.9.0.jar [66.52 ko] > ADD jackson-core-2.9.9.jar [325.63 ko] > ADD jackson-databind-2.9.9.3.jar [1348.39 ko] > ADD jakarta.activation-api-1.2.1.jar [44.40 ko] > > change: +2.01 MB > total : 43.72 MB > > > apache-tomee 8.0.0 microprofile > > ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko] > ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko] > ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko] > ADD jakarta.activation-api-1.2.1.jar [44.40 ko] > > change: +0.52 MB > total : 45.07 MB > > > apache-tomee 8.0.0 plus > > ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko] > ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko] > ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko] > ADD jakarta.activation-api-1.2.1.jar [44.40 ko] > ADD jakarta.xml.soap-api-1.4.1.jar [36.16 ko] > > change: +0.57 MB > total : 61.92 MB > > > apache-tomee 8.0.0 plume > > ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko] > ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko] > ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko] > ADD jakarta.activation-api-1.2.1.jar [44.40 ko] > ADD jakarta.xml.soap-api-1.4.1.jar [36.16 ko] > > change: +0.57 MB > total : 68.76 MB > > > openejb-standalone 8.0.0 > > DEL javax.xml.soap-api-1.3.5.jar [40.81 ko] > ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko] > ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko] > ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko] > ADD jackson-annotations-2.9.0.jar [66.52 ko] > ADD jackson-core-2.9.9.jar [325.63 ko] > ADD jackson-databind-2.9.9.3.jar [1348.39 ko] > ADD jakarta.activation-api-1.2.1.jar [44.40 ko] > ADD jakarta.xml.soap-api-1.4.1.jar [36.16 ko] > > change: +1.98 MB > total : 42.08 MB > > On Wed, Sep 11, 2019 at 11:54 PM Jonathan Gallimore < > jonathan.gallim...@gmail.com> wrote: > >> Hi All, >> >> Here's a first attempt at roll of a TomEE 8.0.0. Please can you take a >> careful look, review, test and provide feedback. >> >> Maven Repo: >> >> https://repository.apache.org/content/repositories/orgapachetomee-1145 >> >> Binaries & Source: >> >> https://dist.apache.org/repos/dist/dev/tomee/staging-1145/tomee-8.0.0/ >> >> Tag: >> >> >> https://gitbox.apache.org/repos/asf?p=tomee.git;a=tag;h=refs/tags/tomee-8.0.0 >> >> Release notes: >> >> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12312320&version=12344635 >> >> Please VOTE: >> >> [+1] Yes, release it >> [+0] Not fussed >> [-1] Don't release, there's a showstopper (please specify what the >> showstopper is) >> >> Vote will be open for 72 hours or as needed. >> >> Thanks >> >> Jon >> >
