Its reasonable to allow a few days as folks might not see messages right away. I'd go ahead with your PR based on the discussion here so far as there appears to be no objections.
Jon On Fri, Nov 1, 2019 at 10:06 PM Jenkins, Rodney J (Rod) < [email protected]> wrote: > I will have something next week for a pull request, if the current one > does not pan out. > > Can I assume that silence is equal(ish) to approval on my previous > comments? If so, that is the direction I will head. > > Have a great weekend!! > > Thanks, > Rod. > > > On 10/29/19, 4:16 AM, "Richard Monson-Haefel" <[email protected]> > wrote: > > Nationwide Information Security Warning: This is an external email. Do > not click on links or open attachments unless you trust the sender. > > ------------------------------------------------------------------------------ > > Hi Jenkins! > > Thanks for reviewing this PR. I think the best thing to do at this > point > is to add your thoughts (as expressed in this email) to the comments > and I > will reach out to person who created the PR. If we don't hear back from > that person in a reasonable amount of time then we can close it and > you can > open your own pull request. Can you do that? > > Richard > > On Mon, Oct 28, 2019 at 11:05 PM Jenkins, Rodney J (Rod) < > [email protected]> wrote: > > > All, > > > > I would like to work on getting the docker images updated. However, > I see > > that someone has already issued a pull request to do this work. In > looking > > at the pull request, I see some things that I would be concerned > with. > > > > > > 1. Added 8443 as an SSL exposed port. As far as I understand > this is > > not in line with how Tomcat is done in Docker. > > 2. Added JDK11, which I did not think was fully working. > > 3. Added `VOLUME` tags for webapps, logs, and, conf. > > 4. Creates a tomee user to run as. (which I would support, just > not the > > way it was done) > > > > > > Here is the link to the pull request that Casell created: > > > https://github.com/tomitribe/docker-tomee/pull/36/commits/ae8f3ac40a350915e0d77788d44b2b9466475e46 > > > > I would be happy to become responsible for the Docker releases. > Given > > that I have been a lurker for some time, I am sure you will want to > oversee > > my efforts as to not give the team a black eye. > > > > Please advise on how I can help here!! > > > > Thanks, > > Rod. > > > > > > -- > Richard Monson-Haefel > https://twitter.com/rmonson > https://www.linkedin.com/in/monsonhaefel/ > > >
