cesarhernandezgt commented on issue #626: TOMEE-2759-Update-Eclipse-Krazo
URL: https://github.com/apache/tomee/pull/626#issuecomment-591124534
 
 
   
   > Since this upgrade only applied for those 3 examples, is there a way to 
include a check to validate the tests for each example are still passing, or is 
something like that already on place? or even covered and implicit to the 
general build?
   
   Currently, if at least one example fails on either compilation, test or 
build, the entire TomEE build fails since `examples` is a maven submodule.
   
   > Should not be the process for upgrading dependencies a more rigorous 
process ? at least from the point of view of documenting, or letting know what 
is the specific benefit of doing it, or why it is important, or by the simple 
fact of checking and ensure full backward compatibility.
   > 
   > Also it could be part of the description of the Dependency upgrade JIRA 
issue?
   
   Good observation. Usually, I have seen the other approach: An issue who's 
bug gets resolved by a dependency update. But I agree that in both cases the 
context of the dependency upgrade should be reflected on the Jira.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to